New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look up bound key status correctly #785

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@wasamasa
Member

wasamasa commented Feb 26, 2017

A user reported on IRC that they failed at customizing Evil to not join lines when deleting with the backspace key. This appears to be the fault of code in evil-maps.el which goes through a list of mappings, then checks whether they're bound and what they're bound to before removing or adding a binding. While this works perfectly for nearly all cases, it fails on remapping definitions such as ([remap delete-backward-char] . evil-delete-backward-char-and-join) as Emacs signals an in-band error by returning a number as definition.

I've taken the liberty of introducing a helper function that handles this case. Perhaps we should look into using it in other places that go for regular lookup-key after merging this PR.

@ivanbrennan

This comment has been minimized.

Show comment
Hide comment
@ivanbrennan

ivanbrennan commented Mar 21, 2017

This fixes #799

@TheBB

This comment has been minimized.

Show comment
Hide comment
@TheBB

TheBB Mar 23, 2017

Member

Merged, thanks!

Member

TheBB commented Mar 23, 2017

Merged, thanks!

@TheBB TheBB closed this Mar 23, 2017

@TheBB TheBB deleted the bugfix-key-lookup branch Mar 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment