Permalink
Browse files

* helm-mode.el (helm-completing-read-handlers-alist): Remove trace-fu…

…nctions*.

When command contain more than one completing-read, same function will be reused,
here `helm-completing-read-symbols' which is correct for symbols but not buffers.
* helm.el: Add comments, no code--change.
  • Loading branch information...
1 parent 256a6ad commit 41f8337ae444843653a436feb996b53f8b0a452d @thierryvolpiatto thierryvolpiatto committed Jan 6, 2013
Showing with 10 additions and 4 deletions.
  1. +6 −2 helm-mode.el
  2. +4 −2 helm.el
View
@@ -31,8 +31,6 @@
(describe-variable . helm-completing-read-symbols)
(debug-on-entry . helm-completing-read-symbols)
(find-function . helm-completing-read-symbols)
- (trace-function . helm-completing-read-symbols)
- (trace-function-background . helm-completing-read-symbols)
(find-tag . helm-completing-read-with-cands-in-buffer)
(ffap-alternate-file . nil))
"Alist of handlers to replace `completing-read', `read-file-name' in `helm-mode'.
@@ -48,6 +46,12 @@ This function prefix name must start by \"helm\".
See `helm-completing-read-symbols' for example.
+Note that this function will be reused for ALL the `completing-read'
+of this command, so it should handle all cases, e.g
+If first `completing-read' complete against symbols and
+second `completing-read' should handle only buffer,
+your specialized function should handle the both.
+
If the value of an entry is nil completion will fall back to
emacs vanilla behavior.
e.g If you want to disable helm completion for `describe-function':
View
@@ -2028,8 +2028,10 @@ Helm plug-ins are realized by this function."
;; Candidates will be filtered later in process filter.
candidates)
((listp candidates)
- ;; Filter candidates now with either `candidate-transformer'
- ;; or `filtered-candidate-transformer' function.
+ ;; Filter candidates now with `candidate-transformer' function maybe
+ ;; otherwise return CANDIDATES which will be passed to
+ ;; `filtered-candidate-transformer', which in turn will maybe filter
+ ;; them or return them unmodified.
(helm-transform-candidates candidates source))
(t (funcall type-error)))))

0 comments on commit 41f8337

Please sign in to comment.