Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The mode line flashes when selecting candidates if helm-follow-mode is enabled. #1593

Closed
Yevgnen opened this issue Sep 3, 2016 · 3 comments

Comments

@Yevgnen
Copy link

Yevgnen commented Sep 3, 2016

When moving around a helm buffer (helm-occur) with helm-follow-mode, the mode line of the origin buffer and helm buffer keep flashing.

helm

It seems that the focus of the window keep changing all the time ?

Minimum config for reproducing is

(require 'package)

(setq package-archives '(("marmalade" . "http://marmalade-repo.org/packages/")
                         ("gnu" . "http://elpa.gnu.org/packages/")
                         ("melpa" . "https://melpa.org/packages/")
                         ("org" . "http://orgmode.org/elpa/")))

(package-initialize)

(unless (and (file-exists-p (expand-file-name "elpa/archives/marmalade" user-emacs-directory))
             (file-exists-p (expand-file-name "elpa/archives/gnu" user-emacs-directory))
             (file-exists-p (expand-file-name "elpa/archives/melpa" user-emacs-directory))
             (file-exists-p (expand-file-name "elpa/archives/org" user-emacs-directory)))
  (package-refresh-contents))

(unless (package-installed-p 'use-package)
  (package-refresh-contents)
  (package-install 'use-package))

(setq use-package-verbose t)
(require 'use-package)

(use-package helm
  :ensure t
  :init
  (setq helm-quick-update t
        helm-move-to-line-cycle-in-source nil
        helm-split-window-default-side 'other
        helm-split-window-in-side-p t
        helm-echo-input-in-header-line nil))

Running an GNU Emacs 25.1.1 (x86_64-apple-darwin13.4.0, NS appkit-1265.21 Version 10.9.5 (Build 13F1911)) of 2016-07-25 with the latest elpa version of helm.

Any help will be appreciated! Thanks !

@xuchunyang
Copy link
Member

I can reproduce.

thierryvolpiatto pushed a commit that referenced this issue Sep 3, 2016
* helm.el (helm-internal): Bind mode-line-in-non-selected-windows.
(helm-execute-persistent-action): Same.
@thierryvolpiatto
Copy link
Member

Yevgnen notifications@github.com writes:

When moving around a helm buffer with helm-follow-mode, the mode line of the origin buffer and helm buffer keep flashing.

helm

It seems that the focus of the window keep changing all the time ?

Of course it is. When for example used with helm-occur, helm jumps in
other buffer, highlight the line and some regexps around and come back to
helm buffer.
I have commited a fix, seems better now, let me know.

Thanks.

Thierry

@xuchunyang
Copy link
Member

I have commited a fix, seems better now, let me know.

Yes, it is better. Thanks.

thierryvolpiatto pushed a commit that referenced this issue Sep 28, 2016
* helm.el (helm-execute-persistent-action):
Remap mode-line face to inactive.
thierryvolpiatto pushed a commit that referenced this issue Sep 28, 2016
* helm.el (helm-execute-persistent-action): Do it.
thierryvolpiatto pushed a commit that referenced this issue Sep 28, 2016
* helm.el (helm-execute-selection-action): Restore face-remapping-alist.
thierryvolpiatto pushed a commit that referenced this issue Sep 28, 2016
* helm.el (helm-execute-selection-action):
These changes are slowing down and finally hanging helm
in rapid execution of persistent action (follow).
thierryvolpiatto pushed a commit that referenced this issue Sep 29, 2016
* helm-imenu.el (helm-imenu-action): Don't use old 'pulse arg.
* helm-utils.el (helm-goto-line): Cleanup overlays here.
(helm-highlight-current-line): Remove usage of 'pulse arg.
(helm-after-action-hook): Cleanup overlays in this hook too.
thierryvolpiatto pushed a commit that referenced this issue Oct 26, 2016
With the most recent changes on this issue
cc1f7c6 * Finally get rid of flashing mode-line (#1579, #1593),
we need to set mode-line-in-non-selected-windows to prevent loosing
mode-line focus when toggling windows.

* helm.el (helm-internal): Do it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants