It's not possible to hit C-l (helm-find-files-down-one-level) in quick succession in helm-find-files #223

Closed
maio opened this Issue Mar 26, 2013 · 16 comments

Projects

None yet

2 participants

@maio
Member
maio commented Mar 26, 2013

only first hit will get registered after one stops to hit C-l. This makes it painful to navigate directory structure.

@thierryvolpiatto
Member

Marian Schubert notifications@github.com writes:

only first hit will get registered after one stops to hit C-l. This makes it painful to navigate directory structure.

I can't reproduce here.

Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997

@maio
Member
maio commented Mar 26, 2013

Hm it has to do something with helm-input-idle-delay I guess. What's the value that you use?

I can reproduce it with default value of 0.3 (bigger makes it even more visible) when I run helm-find-files and I hit C-l in fast succession (probably few times a second). It works fine when I set helm-input-idle-delay to 0, but that makes normal text input painful as it switches to matched directories too fast (while I'm still typing part of already matched directory).

@thierryvolpiatto
Member

Marian Schubert notifications@github.com writes:

Hm it has to do something with helm-input-idle-delay I guess. What's the value that you use?

I am using 0.1, but I have tested with ./emacs-helm.sh that use 0.3 and
it is working as expected.
Please test it with ./emacs-helm.sh (or from emacs -Q)

I can reproduce it with default value of 0.3 (bigger makes it even
more visible) when I run helm-find-files and I hit C-l in fast
succession (probably few times a second). It works fine when I set
helm-input-idle-delay` to 0,

This has no effect it is like using 0.1.

but that makes normal text input painful as it switches to matched
directories too fast (while I'm still typing part of already matched
directory).

You can customize `helm-ff-auto-update-initial-value'.
Or toggle it with


Reply to this email directly or view it on GitHub:
#223 (comment)

Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997

@thierryvolpiatto
Member

Can't reproduce either on WindowsXP running in virtual machine with emacs 24.2.

@maio
Member
maio commented Mar 27, 2013

I have tried it with ./emacs-helm.sh now and it has same problem. I
recorded short video of it

http://www.youtube.com/watch?v=oybbhjEXfho

Notice when I enter /etc/apt/apt.conf.d/ and I keep hitting C-l fast it
deletes apt.conf.d but it doesn't update
view and ignores rest of C-l hits. When I stop hitting C-l it updates view
and lists /etc/apt/

On Wed, Mar 27, 2013 at 7:28 AM, Thierry Volpiatto <notifications@github.com

wrote:

Marian Schubert notifications@github.com writes:

Hm it has to do something with helm-input-idle-delay I guess. What's
the value that you use?

I am using 0.1, but I have tested with ./emacs-helm.sh that use 0.3 and
it is working as expected.
Please test it with ./emacs-helm.sh (or from emacs -Q)

I can reproduce it with default value of 0.3 (bigger makes it even
more visible) when I run helm-find-files and I hit C-l in fast
succession (probably few times a second). It works fine when I set
helm-input-idle-delay` to 0,

This has no effect it is like using 0.1.

but that makes normal text input painful as it switches to matched
directories too fast (while I'm still typing part of already matched
directory).

You can customize `helm-ff-auto-update-initial-value'.
Or toggle it with


Reply to this email directly or view it on GitHub:
#223 (comment)

Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997


Reply to this email directly or view it on GitHubhttps://github.com/emacs-helm/helm/issues/223#issuecomment-15506311
.

@thierryvolpiatto
Member

Hi Marian,

Marian Schubert notifications@github.com writes:

I have tried it with ./emacs-helm.sh now and it has same problem. I
recorded short video of it

http://www.youtube.com/watch?v=oybbhjEXfho

Notice when I enter /etc/apt/apt.conf.d/ and I keep hitting C-l fast it
deletes apt.conf.d but it doesn't update
view and ignores rest of C-l hits. When I stop hitting C-l it updates view
and lists /etc/apt/

I don't think it is a helm problem, but more a slow access to your HD.
It seems that when you hit C-l the command is correctly executed but
helm is long to update the display.
Can you try with same path to hit C-l slowly and wait helm update the
display and tell if that works ?

Are you experimenting slow access to your disk in other places with
emacs ?

It looks also your home directory is updated fast as expected, is it
living on the same disk than /etc ?

Also are you using a laptop on battery mode ?

Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997

@maio
Member
maio commented Mar 27, 2013

Server which has been used when I recorded that video has 8 CPUs and SSD disks. So I don't think it's HW problem.

I did setup of clean EC2 instance where you can try it for yourself. Just ssh syme@maio.62.syme.in (it should have your public key).

There is helm directory with current helm. When I run ./emacs-helm.sh and helm-find-files it behaves same as in that video. So when I hit C-l as fast as I can it only accepts first hit and it doesn't update view until I stop pressing C-l.

@thierryvolpiatto
Member

Marian Schubert notifications@github.com writes:

Server which has been used when I recorded that video has 8 CPUs and SSD disks. So I don't think it's HW problem.
Indeed yes, but the remote access is anyway slower than on a local machine.

I did setup of clean EC2 instance where you can try it for
yourself. Just ssh syme@maio.62.syme.in (it should have your public
key).
Thanks for the access.

There is helm directory with current helm. When I run
./emacs-helm.shandhelm-find-files` it behaves same as in that
video. So when I hit C-l as fast as I can it only accepts first hit
and it doesn't update view until I stop pressing C-l.

Indeed I could reproduce.
If typing C-l slow it works as expected.
The culprit is helm-file-completion-source-p' that usehelm-get-current-source' which return nil unless the display have been
updated (In our case it is slow to update because we are remote) and C-l
just return nil.

I will try to fix that next days.

Thanks.


Reply to this email directly or view it on GitHub:
#223 (comment)

Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997

@maio
Member
maio commented Mar 27, 2013

Thank you.

BTW when helm-input-idle-delay is set to low value like 0.1 it works OK and it updates view immediately (even on that remote host).

@thierryvolpiatto thierryvolpiatto added a commit that referenced this issue Mar 27, 2013
@thierryvolpiatto thierryvolpiatto * helm-files.el (helm-file-completion-source-p): Issue #223 ; Use `he…
…lm-in-file-completion-p'.

* helm.el (helm-in-file-completion-p): New flag.
* helm-mode.el: Use it.
de81e60
@thierryvolpiatto
Member

Marian Schubert notifications@github.com writes:

Thank you.

BTW when helm-input-idle-delay is set to low value like 0.1 it works OK and it updates view immediately (even on that remote host).

It works with 0.1 by chance because the access is quite fast, but it
should fail even with 0.1 if the display comes too late.


Reply to this email directly or view it on GitHub:
#223 (comment)

Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997

@thierryvolpiatto
Member

Did you try the patch installed above ?

@thierryvolpiatto
Member

Please, can you confirm the last change fix your problem ?

@maio
Member
maio commented Mar 29, 2013

Hi, sorry for delay.

Unfortunately mentioned patches don't fix this problem. I have tried to run
./emacs-helm.sh in current master branch (c87dd9d) and it behaves same.
You still can't reproduce this on your local machine? Which OS/Emacs
version are you using?

On Fri, Mar 29, 2013 at 8:19 AM, Thierry Volpiatto <notifications@github.com

wrote:

Please, can you confirm the last change fix your problem ?


Reply to this email directly or view it on GitHubhttps://github.com/emacs-helm/helm/issues/223#issuecomment-15631208
.

@thierryvolpiatto
Member

Hi Marian,

Marian Schubert notifications@github.com writes:

Hi, sorry for delay.
no problem.

Unfortunately mentioned patches don't fix this problem. I have tried to run
./emacs-helm.sh in current master branch (c87dd9d) and it behaves same.
You still can't reproduce this on your local machine? Which OS/Emacs
version are you using?

The last fix in exp branch should work now, I tested it with a value of 0.5
for `helm-input-idle-delay' can you check ?

Thanks.

Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997

@maio
Member
maio commented Mar 29, 2013

Yes it indeed works. Good job!

Thanks.

On Fri, Mar 29, 2013 at 4:20 PM, Thierry Volpiatto <notifications@github.com

wrote:

Hi Marian,

Marian Schubert notifications@github.com writes:

Hi, sorry for delay.
no problem.

Unfortunately mentioned patches don't fix this problem. I have tried to
run
./emacs-helm.sh in current master branch (c87dd9d) and it behaves same.
You still can't reproduce this on your local machine? Which OS/Emacs
version are you using?

The last fix in exp branch should work now, I tested it with a value of 0.5
for `helm-input-idle-delay' can you check ?

Thanks.

Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997

Reply to this email directly or view it on GitHubhttps://github.com/emacs-helm/helm/issues/223#issuecomment-15645397
.

@thierryvolpiatto
Member

Ok thanks, merged in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment