Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

helm-mode conflicts with magit #41

Closed
david opened this Issue Apr 17, 2012 · 8 comments

Comments

Projects
None yet
2 participants

david commented Apr 17, 2012

If I have helm-mode activated, I am unable to use magit's "quick" keybindings. For example, to checkout a branch I usually hit "bb' (First 'b' to show branch menu, second 'b' to checkout the branch". But I'm getting

let*: Wrong type argument: symbolp, (lambda nil (interactive) (magit-key-mode-command (quote magit-checkout)))

david commented Apr 17, 2012

Btw, thanks for helm, it's really, really awesome. :)

Owner

thierryvolpiatto commented Apr 17, 2012

I don't see the relation with helm here. Please send me a precise recipe from emacs -Q to reproduce.
From where are you getting magit and which version? (I am not using magit)
From which buffer are you lauching your magit command ('bb') ?
etc...
Thanks.

Owner

thierryvolpiatto commented Apr 17, 2012

Also turn on debug-on-error and send me the backtrace.

david commented Apr 18, 2012

Hi @thierryvolpiatto, sorry for the delay. Here's the information you requested.

You can get Magit at http://github.com/magit/magit

Minimal configuration using emacs -Q:

(add-to-list 'load-path "/path/to/helm")
(add-to-list 'load-path "/path/to/magit")
(require 'magit)
(require 'helm-config)
(setq debug-on-error t)
(helm-mode 1)

Next do M-x magit-status and give it the path to a git repo. Once you're there hit bb and you'll get the error. Trace is below:

Debugger entered--Lisp error: (wrong-type-argument symbolp (lambda nil (interactive) (magit-key-mode-command (quote magit-checkout))))
  symbol-name((lambda nil (interactive) (magit-key-mode-command (quote magit-checkout))))
  (let* ((current-command this-command) (str-command (symbol-name current-command)) (buf-name (format "*helm-mode-%s*" str-command)) (entry (assq current-command helm-completing-read-handlers-alist)) (def-com (cdr-safe entry)) (str-defcom (and def-com (symbol-name def-com))) (def-args (list prompt collection predicate require-match initial-input hist def inherit-input-method)) (any-args (append def-args (list str-command buf-name))) helm-completion-mode-start-message helm-completion-mode-quit-message (minibuffer-completion-table collection) (minibuffer-completion-predicate predicate) (minibuffer-setup-hook (remove (quote minibuffer-completion-help) minibuffer-setup-hook))) (when (eq def-com (quote ido)) (setq def-com (quote ido-completing-read))) (unless (or (not entry) def-com) (return-from helm-completing-read-default (unwind-protect (progn (helm-mode -1) (apply completing-read-function def-args)) (helm-mode 1)))) (when (or (eq def-com (quote completing-read)) (and (stringp str-defcom) (not (string-match "^helm" str-defcom)))) (helm-mode -1)) (unwind-protect (cond ((and def-com helm-mode) (apply def-com any-args)) ((and def-com (eq def-com (quote ido-completing-read))) (setcar (memq collection def-args) (all-completions "" collection predicate)) (apply def-com def-args)) (def-com (apply def-com def-args)) (t (helm-completing-read-default-1 prompt collection predicate require-match initial-input hist def inherit-input-method str-command buf-name))) (helm-mode 1) (setq this-command current-command)))
  (catch (quote --cl-block-helm-completing-read-default--) (let* ((current-command this-command) (str-command (symbol-name current-command)) (buf-name (format "*helm-mode-%s*" str-command)) (entry (assq current-command helm-completing-read-handlers-alist)) (def-com (cdr-safe entry)) (str-defcom (and def-com (symbol-name def-com))) (def-args (list prompt collection predicate require-match initial-input hist def inherit-input-method)) (any-args (append def-args (list str-command buf-name))) helm-completion-mode-start-message helm-completion-mode-quit-message (minibuffer-completion-table collection) (minibuffer-completion-predicate predicate) (minibuffer-setup-hook (remove (quote minibuffer-completion-help) minibuffer-setup-hook))) (when (eq def-com (quote ido)) (setq def-com (quote ido-completing-read))) (unless (or (not entry) def-com) (return-from helm-completing-read-default (unwind-protect (progn (helm-mode -1) (apply completing-read-function def-args)) (helm-mode 1)))) (when (or (eq def-com (quote completing-read)) (and (stringp str-defcom) (not (string-match "^helm" str-defcom)))) (helm-mode -1)) (unwind-protect (cond ((and def-com helm-mode) (apply def-com any-args)) ((and def-com (eq def-com (quote ido-completing-read))) (setcar (memq collection def-args) (all-completions "" collection predicate)) (apply def-com def-args)) (def-com (apply def-com def-args)) (t (helm-completing-read-default-1 prompt collection predicate require-match initial-input hist def inherit-input-method str-command buf-name))) (helm-mode 1) (setq this-command current-command))))
  (cl-block-wrapper (catch (quote --cl-block-helm-completing-read-default--) (let* ((current-command this-command) (str-command (symbol-name current-command)) (buf-name (format "*helm-mode-%s*" str-command)) (entry (assq current-command helm-completing-read-handlers-alist)) (def-com (cdr-safe entry)) (str-defcom (and def-com (symbol-name def-com))) (def-args (list prompt collection predicate require-match initial-input hist def inherit-input-method)) (any-args (append def-args (list str-command buf-name))) helm-completion-mode-start-message helm-completion-mode-quit-message (minibuffer-completion-table collection) (minibuffer-completion-predicate predicate) (minibuffer-setup-hook (remove (quote minibuffer-completion-help) minibuffer-setup-hook))) (when (eq def-com (quote ido)) (setq def-com (quote ido-completing-read))) (unless (or (not entry) def-com) (return-from helm-completing-read-default (unwind-protect (progn (helm-mode -1) (apply completing-read-function def-args)) (helm-mode 1)))) (when (or (eq def-com (quote completing-read)) (and (stringp str-defcom) (not (string-match "^helm" str-defcom)))) (helm-mode -1)) (unwind-protect (cond ((and def-com helm-mode) (apply def-com any-args)) ((and def-com (eq def-com ...)) (setcar (memq collection def-args) (all-completions "" collection predicate)) (apply def-com def-args)) (def-com (apply def-com def-args)) (t (helm-completing-read-default-1 prompt collection predicate require-match initial-input hist def inherit-input-method str-command buf-name))) (helm-mode 1) (setq this-command current-command)))))
  (block helm-completing-read-default (let* ((current-command this-command) (str-command (symbol-name current-command)) (buf-name (format "*helm-mode-%s*" str-command)) (entry (assq current-command helm-completing-read-handlers-alist)) (def-com (cdr-safe entry)) (str-defcom (and def-com (symbol-name def-com))) (def-args (list prompt collection predicate require-match initial-input hist def inherit-input-method)) (any-args (append def-args (list str-command buf-name))) helm-completion-mode-start-message helm-completion-mode-quit-message (minibuffer-completion-table collection) (minibuffer-completion-predicate predicate) (minibuffer-setup-hook (remove (quote minibuffer-completion-help) minibuffer-setup-hook))) (when (eq def-com (quote ido)) (setq def-com (quote ido-completing-read))) (unless (or (not entry) def-com) (return-from helm-completing-read-default (unwind-protect (progn (helm-mode -1) (apply completing-read-function def-args)) (helm-mode 1)))) (when (or (eq def-com (quote completing-read)) (and (stringp str-defcom) (not (string-match "^helm" str-defcom)))) (helm-mode -1)) (unwind-protect (cond ((and def-com helm-mode) (apply def-com any-args)) ((and def-com (eq def-com (quote ido-completing-read))) (setcar (memq collection def-args) (all-completions "" collection predicate)) (apply def-com def-args)) (def-com (apply def-com def-args)) (t (helm-completing-read-default-1 prompt collection predicate require-match initial-input hist def inherit-input-method str-command buf-name))) (helm-mode 1) (setq this-command current-command))))
  helm-completing-read-default("Switch to: " (("dl/comment_notifications" . "dl/comment_notifications") ("dl/fixes_apr_5" . "dl/fixes_apr_5") ("dl/follow_friends" . "dl/follow_friends") ("dl/friends" . "dl/friends") ("dl/global_track_search" . "dl/global_track_search") ("dl/lighter_splashboards" . "dl/lighter_splashboards") ("dl/public_beta" . "dl/public_beta") ("dl/public_beta_april" . "dl/public_beta_april") ("dl/reporting" . "dl/reporting") ("dl/restore_forgot_password" . "dl/restore_forgot_password") ("dl/roll_down" . "dl/roll_down") ("dl/serializers" . "dl/serializers") ("dl/splashboards" . "dl/splashboards") ("dl/splashboards2" . "dl/splashboards2") ("dl/splashboards3" . "dl/splashboards3") ("dl/suggested_splashers" . "dl/suggested_splashers") ("dl/suggested_splashers_fix" . "dl/suggested_splashers_fix") ("dl/track_artwork" . "dl/track_artwork") ("dl/two_tiered_search" . "dl/two_tiered_search") ("dl/view_splash" . "dl/view_splash") ("sjs/invite_screen" . "sjs/invite_screen") ("splash_preview" . "splash_preview") ("cas/fixes-arp-10 (origin)" . "refs/remotes/origin/cas/fixes-arp-10") ("cas/fixes_apr_11 (origin)" . "refs/remotes/origin/cas/fixes_apr_11") ("cas/following (origin)" . "refs/remotes/origin/cas/following") ("cas/itunes_epf (origin)" . "refs/remotes/origin/cas/itunes_epf") ("cas/user-feed (origin)" . "refs/remotes/origin/cas/user-feed") ("dl/fixes_apr_5 (origin)" . "refs/remotes/origin/dl/fixes_apr_5") ("dl/friends (origin)" . "refs/remotes/origin/dl/friends") ("dl/global_track_search (origin)" . "refs/remotes/origin/dl/global_track_search") ("dl/lighter_splashboards (origin)" . "refs/remotes/origin/dl/lighter_splashboards") ("dl/public_beta (origin)" . "refs/remotes/origin/dl/public_beta") ("dl/public_beta_april (origin)" . "refs/remotes/origin/dl/public_beta_april") ("dl/reporting (origin)" . "refs/remotes/origin/dl/reporting") ("dl/roll_down (origin)" . "refs/remotes/origin/dl/roll_down") ("dl/splashboards (origin)" . "refs/remotes/origin/dl/splashboards") ("dl/track_artwork (origin)" . "refs/remotes/origin/dl/track_artwork") ("dl/two_tiered_search (origin)" . "refs/remotes/origin/dl/two_tiered_search") ("dl/view_splash (origin)" . "refs/remotes/origin/dl/view_splash") ("fb/19408167-email_notification_preference (origin)" . "refs/remotes/origin/fb/19408167-email_notification_preference") ("fb/19469687-invite_twitter_friends (origin)" . "refs/remotes/origin/fb/19469687-invite_twitter_friends") ("fb/21687011-ajaxify_setting_modal (origin)" . "refs/remotes/origin/fb/21687011-ajaxify_setting_modal") ("fb/21687011-ajaxify_settings_modal (origin)" . "refs/remotes/origin/fb/21687011-ajaxify_settings_modal") ("fb/22398199-search_users_by_lastname_too (origin)" . "refs/remotes/origin/fb/22398199-search_users_by_lastname_too") ("fb/22468649-change_fail_file_message (origin)" . "refs/remotes/origin/fb/22468649-change_fail_file_message") ("fb/22506837-minimize_comment_box (origin)" . "refs/remotes/origin/fb/22506837-minimize_comment_box") ("fb/22745323-share_referral_url_to_twitter (origin)" . "refs/remotes/origin/fb/22745323-share_referral_url_to_twitter") ("fb/22745325-share_referral_url_to_facebook (origin)" . "refs/remotes/origin/fb/22745325-share_referral_url_to_facebook") ("fb/22795025-email_invitations (origin)" . "refs/remotes/origin/fb/22795025-email_invitations") ("fb/22843323-style_social_connect_buttons (origin)" . "refs/remotes/origin/fb/22843323-style_social_connect_buttons") ...) nil nil nil magit-read-rev-history nil nil)
  completing-read("Switch to: " (("dl/comment_notifications" . "dl/comment_notifications") ("dl/fixes_apr_5" . "dl/fixes_apr_5") ("dl/follow_friends" . "dl/follow_friends") ("dl/friends" . "dl/friends") ("dl/global_track_search" . "dl/global_track_search") ("dl/lighter_splashboards" . "dl/lighter_splashboards") ("dl/public_beta" . "dl/public_beta") ("dl/public_beta_april" . "dl/public_beta_april") ("dl/reporting" . "dl/reporting") ("dl/restore_forgot_password" . "dl/restore_forgot_password") ("dl/roll_down" . "dl/roll_down") ("dl/serializers" . "dl/serializers") ("dl/splashboards" . "dl/splashboards") ("dl/splashboards2" . "dl/splashboards2") ("dl/splashboards3" . "dl/splashboards3") ("dl/suggested_splashers" . "dl/suggested_splashers") ("dl/suggested_splashers_fix" . "dl/suggested_splashers_fix") ("dl/track_artwork" . "dl/track_artwork") ("dl/two_tiered_search" . "dl/two_tiered_search") ("dl/view_splash" . "dl/view_splash") ("sjs/invite_screen" . "sjs/invite_screen") ("splash_preview" . "splash_preview") ("cas/fixes-arp-10 (origin)" . "refs/remotes/origin/cas/fixes-arp-10") ("cas/fixes_apr_11 (origin)" . "refs/remotes/origin/cas/fixes_apr_11") ("cas/following (origin)" . "refs/remotes/origin/cas/following") ("cas/itunes_epf (origin)" . "refs/remotes/origin/cas/itunes_epf") ("cas/user-feed (origin)" . "refs/remotes/origin/cas/user-feed") ("dl/fixes_apr_5 (origin)" . "refs/remotes/origin/dl/fixes_apr_5") ("dl/friends (origin)" . "refs/remotes/origin/dl/friends") ("dl/global_track_search (origin)" . "refs/remotes/origin/dl/global_track_search") ("dl/lighter_splashboards (origin)" . "refs/remotes/origin/dl/lighter_splashboards") ("dl/public_beta (origin)" . "refs/remotes/origin/dl/public_beta") ("dl/public_beta_april (origin)" . "refs/remotes/origin/dl/public_beta_april") ("dl/reporting (origin)" . "refs/remotes/origin/dl/reporting") ("dl/roll_down (origin)" . "refs/remotes/origin/dl/roll_down") ("dl/splashboards (origin)" . "refs/remotes/origin/dl/splashboards") ("dl/track_artwork (origin)" . "refs/remotes/origin/dl/track_artwork") ("dl/two_tiered_search (origin)" . "refs/remotes/origin/dl/two_tiered_search") ("dl/view_splash (origin)" . "refs/remotes/origin/dl/view_splash") ("fb/19408167-email_notification_preference (origin)" . "refs/remotes/origin/fb/19408167-email_notification_preference") ("fb/19469687-invite_twitter_friends (origin)" . "refs/remotes/origin/fb/19469687-invite_twitter_friends") ("fb/21687011-ajaxify_setting_modal (origin)" . "refs/remotes/origin/fb/21687011-ajaxify_setting_modal") ("fb/21687011-ajaxify_settings_modal (origin)" . "refs/remotes/origin/fb/21687011-ajaxify_settings_modal") ("fb/22398199-search_users_by_lastname_too (origin)" . "refs/remotes/origin/fb/22398199-search_users_by_lastname_too") ("fb/22468649-change_fail_file_message (origin)" . "refs/remotes/origin/fb/22468649-change_fail_file_message") ("fb/22506837-minimize_comment_box (origin)" . "refs/remotes/origin/fb/22506837-minimize_comment_box") ("fb/22745323-share_referral_url_to_twitter (origin)" . "refs/remotes/origin/fb/22745323-share_referral_url_to_twitter") ("fb/22745325-share_referral_url_to_facebook (origin)" . "refs/remotes/origin/fb/22745325-share_referral_url_to_facebook") ("fb/22795025-email_invitations (origin)" . "refs/remotes/origin/fb/22795025-email_invitations") ("fb/22843323-style_social_connect_buttons (origin)" . "refs/remotes/origin/fb/22843323-style_social_connect_buttons") ...) nil nil nil magit-read-rev-history nil)
  magit-builtin-completing-read("Switch to: " (("dl/comment_notifications" . "dl/comment_notifications") ("dl/fixes_apr_5" . "dl/fixes_apr_5") ("dl/follow_friends" . "dl/follow_friends") ("dl/friends" . "dl/friends") ("dl/global_track_search" . "dl/global_track_search") ("dl/lighter_splashboards" . "dl/lighter_splashboards") ("dl/public_beta" . "dl/public_beta") ("dl/public_beta_april" . "dl/public_beta_april") ("dl/reporting" . "dl/reporting") ("dl/restore_forgot_password" . "dl/restore_forgot_password") ("dl/roll_down" . "dl/roll_down") ("dl/serializers" . "dl/serializers") ("dl/splashboards" . "dl/splashboards") ("dl/splashboards2" . "dl/splashboards2") ("dl/splashboards3" . "dl/splashboards3") ("dl/suggested_splashers" . "dl/suggested_splashers") ("dl/suggested_splashers_fix" . "dl/suggested_splashers_fix") ("dl/track_artwork" . "dl/track_artwork") ("dl/two_tiered_search" . "dl/two_tiered_search") ("dl/view_splash" . "dl/view_splash") ("sjs/invite_screen" . "sjs/invite_screen") ("splash_preview" . "splash_preview") ("cas/fixes-arp-10 (origin)" . "refs/remotes/origin/cas/fixes-arp-10") ("cas/fixes_apr_11 (origin)" . "refs/remotes/origin/cas/fixes_apr_11") ("cas/following (origin)" . "refs/remotes/origin/cas/following") ("cas/itunes_epf (origin)" . "refs/remotes/origin/cas/itunes_epf") ("cas/user-feed (origin)" . "refs/remotes/origin/cas/user-feed") ("dl/fixes_apr_5 (origin)" . "refs/remotes/origin/dl/fixes_apr_5") ("dl/friends (origin)" . "refs/remotes/origin/dl/friends") ("dl/global_track_search (origin)" . "refs/remotes/origin/dl/global_track_search") ("dl/lighter_splashboards (origin)" . "refs/remotes/origin/dl/lighter_splashboards") ("dl/public_beta (origin)" . "refs/remotes/origin/dl/public_beta") ("dl/public_beta_april (origin)" . "refs/remotes/origin/dl/public_beta_april") ("dl/reporting (origin)" . "refs/remotes/origin/dl/reporting") ("dl/roll_down (origin)" . "refs/remotes/origin/dl/roll_down") ("dl/splashboards (origin)" . "refs/remotes/origin/dl/splashboards") ("dl/track_artwork (origin)" . "refs/remotes/origin/dl/track_artwork") ("dl/two_tiered_search (origin)" . "refs/remotes/origin/dl/two_tiered_search") ("dl/view_splash (origin)" . "refs/remotes/origin/dl/view_splash") ("fb/19408167-email_notification_preference (origin)" . "refs/remotes/origin/fb/19408167-email_notification_preference") ("fb/19469687-invite_twitter_friends (origin)" . "refs/remotes/origin/fb/19469687-invite_twitter_friends") ("fb/21687011-ajaxify_setting_modal (origin)" . "refs/remotes/origin/fb/21687011-ajaxify_setting_modal") ("fb/21687011-ajaxify_settings_modal (origin)" . "refs/remotes/origin/fb/21687011-ajaxify_settings_modal") ("fb/22398199-search_users_by_lastname_too (origin)" . "refs/remotes/origin/fb/22398199-search_users_by_lastname_too") ("fb/22468649-change_fail_file_message (origin)" . "refs/remotes/origin/fb/22468649-change_fail_file_message") ("fb/22506837-minimize_comment_box (origin)" . "refs/remotes/origin/fb/22506837-minimize_comment_box") ("fb/22745323-share_referral_url_to_twitter (origin)" . "refs/remotes/origin/fb/22745323-share_referral_url_to_twitter") ("fb/22745325-share_referral_url_to_facebook (origin)" . "refs/remotes/origin/fb/22745325-share_referral_url_to_facebook") ("fb/22795025-email_invitations (origin)" . "refs/remotes/origin/fb/22795025-email_invitations") ("fb/22843323-style_social_connect_buttons (origin)" . "refs/remotes/origin/fb/22843323-style_social_connect_buttons") ...) nil nil nil magit-read-rev-history nil)
  funcall(magit-builtin-completing-read "Switch to: " (("dl/comment_notifications" . "dl/comment_notifications") ("dl/fixes_apr_5" . "dl/fixes_apr_5") ("dl/follow_friends" . "dl/follow_friends") ("dl/friends" . "dl/friends") ("dl/global_track_search" . "dl/global_track_search") ("dl/lighter_splashboards" . "dl/lighter_splashboards") ("dl/public_beta" . "dl/public_beta") ("dl/public_beta_april" . "dl/public_beta_april") ("dl/reporting" . "dl/reporting") ("dl/restore_forgot_password" . "dl/restore_forgot_password") ("dl/roll_down" . "dl/roll_down") ("dl/serializers" . "dl/serializers") ("dl/splashboards" . "dl/splashboards") ("dl/splashboards2" . "dl/splashboards2") ("dl/splashboards3" . "dl/splashboards3") ("dl/suggested_splashers" . "dl/suggested_splashers") ("dl/suggested_splashers_fix" . "dl/suggested_splashers_fix") ("dl/track_artwork" . "dl/track_artwork") ("dl/two_tiered_search" . "dl/two_tiered_search") ("dl/view_splash" . "dl/view_splash") ("sjs/invite_screen" . "sjs/invite_screen") ("splash_preview" . "splash_preview") ("cas/fixes-arp-10 (origin)" . "refs/remotes/origin/cas/fixes-arp-10") ("cas/fixes_apr_11 (origin)" . "refs/remotes/origin/cas/fixes_apr_11") ("cas/following (origin)" . "refs/remotes/origin/cas/following") ("cas/itunes_epf (origin)" . "refs/remotes/origin/cas/itunes_epf") ("cas/user-feed (origin)" . "refs/remotes/origin/cas/user-feed") ("dl/fixes_apr_5 (origin)" . "refs/remotes/origin/dl/fixes_apr_5") ("dl/friends (origin)" . "refs/remotes/origin/dl/friends") ("dl/global_track_search (origin)" . "refs/remotes/origin/dl/global_track_search") ("dl/lighter_splashboards (origin)" . "refs/remotes/origin/dl/lighter_splashboards") ("dl/public_beta (origin)" . "refs/remotes/origin/dl/public_beta") ("dl/public_beta_april (origin)" . "refs/remotes/origin/dl/public_beta_april") ("dl/reporting (origin)" . "refs/remotes/origin/dl/reporting") ("dl/roll_down (origin)" . "refs/remotes/origin/dl/roll_down") ("dl/splashboards (origin)" . "refs/remotes/origin/dl/splashboards") ("dl/track_artwork (origin)" . "refs/remotes/origin/dl/track_artwork") ("dl/two_tiered_search (origin)" . "refs/remotes/origin/dl/two_tiered_search") ("dl/view_splash (origin)" . "refs/remotes/origin/dl/view_splash") ("fb/19408167-email_notification_preference (origin)" . "refs/remotes/origin/fb/19408167-email_notification_preference") ("fb/19469687-invite_twitter_friends (origin)" . "refs/remotes/origin/fb/19469687-invite_twitter_friends") ("fb/21687011-ajaxify_setting_modal (origin)" . "refs/remotes/origin/fb/21687011-ajaxify_setting_modal") ("fb/21687011-ajaxify_settings_modal (origin)" . "refs/remotes/origin/fb/21687011-ajaxify_settings_modal") ("fb/22398199-search_users_by_lastname_too (origin)" . "refs/remotes/origin/fb/22398199-search_users_by_lastname_too") ("fb/22468649-change_fail_file_message (origin)" . "refs/remotes/origin/fb/22468649-change_fail_file_message") ("fb/22506837-minimize_comment_box (origin)" . "refs/remotes/origin/fb/22506837-minimize_comment_box") ("fb/22745323-share_referral_url_to_twitter (origin)" . "refs/remotes/origin/fb/22745323-share_referral_url_to_twitter") ("fb/22745325-share_referral_url_to_facebook (origin)" . "refs/remotes/origin/fb/22745325-share_referral_url_to_facebook") ("fb/22795025-email_invitations (origin)" . "refs/remotes/origin/fb/22795025-email_invitations") ("fb/22843323-style_social_connect_buttons (origin)" . "refs/remotes/origin/fb/22843323-style_social_connect_buttons") ...) nil nil nil magit-read-rev-history nil)
  magit-completing-read("Switch to: " (("dl/comment_notifications" . "dl/comment_notifications") ("dl/fixes_apr_5" . "dl/fixes_apr_5") ("dl/follow_friends" . "dl/follow_friends") ("dl/friends" . "dl/friends") ("dl/global_track_search" . "dl/global_track_search") ("dl/lighter_splashboards" . "dl/lighter_splashboards") ("dl/public_beta" . "dl/public_beta") ("dl/public_beta_april" . "dl/public_beta_april") ("dl/reporting" . "dl/reporting") ("dl/restore_forgot_password" . "dl/restore_forgot_password") ("dl/roll_down" . "dl/roll_down") ("dl/serializers" . "dl/serializers") ("dl/splashboards" . "dl/splashboards") ("dl/splashboards2" . "dl/splashboards2") ("dl/splashboards3" . "dl/splashboards3") ("dl/suggested_splashers" . "dl/suggested_splashers") ("dl/suggested_splashers_fix" . "dl/suggested_splashers_fix") ("dl/track_artwork" . "dl/track_artwork") ("dl/two_tiered_search" . "dl/two_tiered_search") ("dl/view_splash" . "dl/view_splash") ("sjs/invite_screen" . "sjs/invite_screen") ("splash_preview" . "splash_preview") ("cas/fixes-arp-10 (origin)" . "refs/remotes/origin/cas/fixes-arp-10") ("cas/fixes_apr_11 (origin)" . "refs/remotes/origin/cas/fixes_apr_11") ("cas/following (origin)" . "refs/remotes/origin/cas/following") ("cas/itunes_epf (origin)" . "refs/remotes/origin/cas/itunes_epf") ("cas/user-feed (origin)" . "refs/remotes/origin/cas/user-feed") ("dl/fixes_apr_5 (origin)" . "refs/remotes/origin/dl/fixes_apr_5") ("dl/friends (origin)" . "refs/remotes/origin/dl/friends") ("dl/global_track_search (origin)" . "refs/remotes/origin/dl/global_track_search") ("dl/lighter_splashboards (origin)" . "refs/remotes/origin/dl/lighter_splashboards") ("dl/public_beta (origin)" . "refs/remotes/origin/dl/public_beta") ("dl/public_beta_april (origin)" . "refs/remotes/origin/dl/public_beta_april") ("dl/reporting (origin)" . "refs/remotes/origin/dl/reporting") ("dl/roll_down (origin)" . "refs/remotes/origin/dl/roll_down") ("dl/splashboards (origin)" . "refs/remotes/origin/dl/splashboards") ("dl/track_artwork (origin)" . "refs/remotes/origin/dl/track_artwork") ("dl/two_tiered_search (origin)" . "refs/remotes/origin/dl/two_tiered_search") ("dl/view_splash (origin)" . "refs/remotes/origin/dl/view_splash") ("fb/19408167-email_notification_preference (origin)" . "refs/remotes/origin/fb/19408167-email_notification_preference") ("fb/19469687-invite_twitter_friends (origin)" . "refs/remotes/origin/fb/19469687-invite_twitter_friends") ("fb/21687011-ajaxify_setting_modal (origin)" . "refs/remotes/origin/fb/21687011-ajaxify_setting_modal") ("fb/21687011-ajaxify_settings_modal (origin)" . "refs/remotes/origin/fb/21687011-ajaxify_settings_modal") ("fb/22398199-search_users_by_lastname_too (origin)" . "refs/remotes/origin/fb/22398199-search_users_by_lastname_too") ("fb/22468649-change_fail_file_message (origin)" . "refs/remotes/origin/fb/22468649-change_fail_file_message") ("fb/22506837-minimize_comment_box (origin)" . "refs/remotes/origin/fb/22506837-minimize_comment_box") ("fb/22745323-share_referral_url_to_twitter (origin)" . "refs/remotes/origin/fb/22745323-share_referral_url_to_twitter") ("fb/22745325-share_referral_url_to_facebook (origin)" . "refs/remotes/origin/fb/22745325-share_referral_url_to_facebook") ("fb/22795025-email_invitations (origin)" . "refs/remotes/origin/fb/22795025-email_invitations") ("fb/22843323-style_social_connect_buttons (origin)" . "refs/remotes/origin/fb/22843323-style_social_connect_buttons") ...) nil nil nil magit-read-rev-history nil)
  (let* ((interesting-refs (magit-list-interesting-refs (or uninteresting magit-uninteresting-refs))) (reply (magit-completing-read (concat prompt ": ") interesting-refs nil nil nil (quote magit-read-rev-history) default)) (rev (or (cdr (assoc reply interesting-refs)) reply))) (if (string= rev "") nil rev))
  magit-read-rev("Switch to" nil ("refs/heads/master$" "refs/remotes/\\([^/]+\\)/HEAD$" "refs/stash"))
  (let ((current-branch (magit-get-current-branch)) (default (magit-default-rev))) (magit-read-rev "Switch to" (unless (string= current-branch default) default) (if current-branch (cons (concat "refs/heads/" current-branch "$") magit-uninteresting-refs) magit-uninteresting-refs)))
  (list (let ((current-branch (magit-get-current-branch)) (default (magit-default-rev))) (magit-read-rev "Switch to" (unless (string= current-branch default) default) (if current-branch (cons (concat "refs/heads/" current-branch "$") magit-uninteresting-refs) magit-uninteresting-refs))))
  call-interactively(magit-checkout)
  (progn (call-interactively func))
  (if func (progn (call-interactively func)))
  (when func (call-interactively func))
  (let ((magit-custom-options (append args magit-key-mode-current-options)) (current-prefix-arg (or current-prefix-arg magit-key-mode-prefix))) (set-window-configuration magit-log-mode-window-conf) (when func (call-interactively func)) (magit-key-mode-kill-buffer))
  (let ((args (quote nil))) (maphash (lambda (k v) (push (concat k (shell-quote-argument v)) args)) magit-key-mode-current-args) (let ((magit-custom-options (append args magit-key-mode-current-options)) (current-prefix-arg (or current-prefix-arg magit-key-mode-prefix))) (set-window-configuration magit-log-mode-window-conf) (when func (call-interactively func)) (magit-key-mode-kill-buffer)))
  magit-key-mode-command(magit-checkout)
  (lambda nil (interactive) (magit-key-mode-command (quote magit-checkout)))()
  call-interactively((lambda nil (interactive) (magit-key-mode-command (quote magit-checkout))) nil nil)

david commented Apr 18, 2012

Btw, I'm using the emacs-snapshot packages on Ubuntu.

Owner

thierryvolpiatto commented Apr 18, 2012

Ok, good.
The problem is magit use a lambda somewhere (Indeed it is not magit but defstruct I think that build a lambda in background, didn't verify though) and `this-command' take the value of this sexp.
Anyway it is fixed here, I will install this change now. (You will end up with a helm completion buffer named
"helm-mode-anonymous")
Thanks for your report ;-)

@thierryvolpiatto thierryvolpiatto added a commit that referenced this issue Apr 18, 2012

@thierryvolpiatto thierryvolpiatto * helm-mode (helm-completing-read-default): Fix issue #41 helm-mode c…
…onflicts with magit.

* helm-locate.el: Use file-name-history (only basename).
2d09d7b

david commented Apr 18, 2012

Works like a charm, thanks a lot. :)

I'll close this if you don't mind.

@david david closed this Apr 18, 2012

Owner

thierryvolpiatto commented Apr 19, 2012

David Leal
reply@reply.github.com
writes:

Works like a charm, thanks a lot. :)

I'll close this if you don't mind.
Ok thanks.

Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment