helm-imenu-in-all-buffers in separate sources (#1705). #1707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* helm-imenu.el (helm-imenu-in-all-buffers-separate-sources): New user var. (helm-imenu-collect-sources-from-all-buffers): New fn. (helm-imenu-in-all-buffers): Use it.
* helm-imenu.el (helm-imenu-collect-sources-from-all-buffers): Do it.
#1705). * helm-imenu.el (helm-imenu-in-all-buffers): Do it.
xiongtx
reviewed
Mar 9, 2017
helm-imenu.el
Outdated
| (cl-loop with cur-buf = (current-buffer) | ||
| for b in lst | ||
| for count from 1 | ||
| when (and (with-current-buffer b |
There was a problem hiding this comment.
We can use with-current-buffer outside the and to avoid repetition.
xiongtx
reviewed
Mar 9, 2017
| (helm :sources 'helm-source-imenu-all | ||
| helm-imenu-execute-action-at-once-if-one) | ||
| (helm--maybe-use-default-as-input | ||
| (not (null (memq 'helm-source-imenu-all |
There was a problem hiding this comment.
Why is (not (null... necessary? Isn't the generalized boolean from memq sufficient?
There was a problem hiding this comment.
memq is not returning a boolean so it is cleaner to return a boolean, though yes it would work also of course with a list instead of t.
* helm-imenu.el (helm-imenu-candidates-in-all-buffers): Take now one optional arg. (helm-imenu-in-all-buffers): Use it.
* helm-imenu.el (helm-imenu-map): Do it.
* helm.el (helm-map): Do it.
|
Tianxiang Xiong <notifications@github.com> writes:
We can use with-current-buffer outside the and to avoid repetition.
Yes ;-) done.
Thanks.
…--
Thierry
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(helm-imenu-collect-sources-from-all-buffers): New fn.
(helm-imenu-in-all-buffers): Use it.