Start fixing tramp completion user-error for emacs-24.4. #225

Merged
merged 3 commits into from Mar 29, 2013

Conversation

Projects
None yet
1 participant
@thierryvolpiatto
Member

thierryvolpiatto commented Mar 28, 2013

  • helm-files.el (helm-find-files-get-candidates): let-bind non-essential
  • helm-utils.el: Comment tramp-dissect-file-name defadvice.
  • helm.el: let-bind non-essential to t on helm startup.
Start fixing tramp completion user-error for emacs-24.4.
* helm-files.el (helm-find-files-get-candidates): let-bind non-essential
* helm-utils.el: Comment tramp-dissect-file-name defadvice.
* helm.el: let-bind non-essential to t on helm startup.
@thierryvolpiatto

This comment has been minimized.

Show comment Hide comment
@thierryvolpiatto

thierryvolpiatto Mar 28, 2013

Member

Still have problem with host completion now, fix it, now behavior of helm-basename is changed:

(helm-basename "/ssh:foo")

will not work anymore.

Member

thierryvolpiatto commented Mar 28, 2013

Still have problem with host completion now, fix it, now behavior of helm-basename is changed:

(helm-basename "/ssh:foo")

will not work anymore.

thierryvolpiatto added some commits Mar 28, 2013

* helm-files.el (helm-find-files-transformer): Fix basename on invali…
…d tramp entries.

(helm-ff-highlight-files): same
* helm-utils.el (helm-ff-get-host-from-tramp-invalid-fname): New.
(helm-basename): Always use non-essential.
@thierryvolpiatto

This comment has been minimized.

Show comment Hide comment
@thierryvolpiatto

thierryvolpiatto Mar 29, 2013

Member

Will need probably to modify helm-create-tramp-name when file-remote-p will be fixed upstream.

Member

thierryvolpiatto commented Mar 29, 2013

Will need probably to modify helm-create-tramp-name when file-remote-p will be fixed upstream.

thierryvolpiatto added a commit that referenced this pull request Mar 29, 2013

Merge pull request #225 from emacs-helm/tramp-completion-24.4
Start fixing tramp completion user-error for emacs-24.4.

@thierryvolpiatto thierryvolpiatto merged commit f1bc6bd into master Mar 29, 2013

@thierryvolpiatto thierryvolpiatto deleted the tramp-completion-24.4 branch Mar 29, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment