Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lsp java is not properly re-linting/compiling buffers #195

Open
didibus opened this issue Feb 20, 2020 · 5 comments
Open

Lsp java is not properly re-linting/compiling buffers #195

didibus opened this issue Feb 20, 2020 · 5 comments

Comments

@didibus
Copy link

didibus commented Feb 20, 2020

It seems like as I change Java code in a buffer, I don't get an up to date linting. I keep having to run lsp-workspace-restart for it to update, or I need to run the tests.

What is supposed to recompute this? Is it the file watchers? Should it happen as I type? Should it happen on save?

@yyoncho
Copy link
Member

yyoncho commented Feb 20, 2020

I think that it might be a potential regression from emacs-lsp/lsp-mode#1419 . Do you have steps to reproduce? (preferably over hello world application).

@yyoncho
Copy link
Member

yyoncho commented Feb 20, 2020

Can you test yyoncho/lsp-mode@7ce3ad5 ? I believe that the issue was that we do not flush delayed changes before sending notifications.

@didibus
Copy link
Author

didibus commented Feb 20, 2020

Hum, tried it a little, and it does seem to fix it. I'll try it some more and confirm.

@yyoncho
Copy link
Member

yyoncho commented Feb 20, 2020

I think I found the issue - I will revert part of aforementioned commit

yyoncho added a commit to yyoncho/lsp-mode that referenced this issue Feb 20, 2020
@yyoncho
Copy link
Member

yyoncho commented Feb 20, 2020

yyoncho/lsp-mode@97e5e4a this one should fix the issue.

@yyoncho yyoncho reopened this Feb 20, 2020
yyoncho added a commit to yyoncho/lsp-mode that referenced this issue Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants