Skip to content

Check that mvn-executable exists before quoting spaces.#177

Merged
yyoncho merged 1 commit into
emacs-lsp:masterfrom
ebobby:master
Nov 15, 2019
Merged

Check that mvn-executable exists before quoting spaces.#177
yyoncho merged 1 commit into
emacs-lsp:masterfrom
ebobby:master

Conversation

@ebobby
Copy link
Copy Markdown
Contributor

@ebobby ebobby commented Nov 15, 2019

The code assumed mvn-executable was always non-nil and it failed on initial server install.

@yyoncho yyoncho merged commit b77a30e into emacs-lsp:master Nov 15, 2019
@yyoncho
Copy link
Copy Markdown
Member

yyoncho commented Nov 15, 2019

Thank you!

@ebobby
Copy link
Copy Markdown
Contributor Author

ebobby commented Nov 15, 2019

You're welcome. Thanks for building this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants