/lsp-mode

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use lsp-format-region as indent-region-function #398

Closed
muffinmad opened this Issue Jul 19, 2018 · 2 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@muffinmad @vibhavp @j3kyl
@muffinmad

muffinmad commented Jul 19, 2018

Region formatting may include various corrections like whitespace around operators etc. but indent-region-function must be used just for indentation.

lsp-mode/lsp-methods.el

Line 894 in 5ea5c63

(setq-local indent-region-function #'lsp-format-region))

@vibhavp

This comment has been minimized.

Show comment
Hide comment
@vibhavp

vibhavp Aug 18, 2018

Member

Doing that would break someone else's setup. You could set lsp-enable-indentation to nil instead.
Member

vibhavp commented Aug 18, 2018

Doing that would break someone else's setup. You could set lsp-enable-indentation to nil instead.

@vibhavp vibhavp closed this Aug 18, 2018

@j3kyl

This comment has been minimized.

Show comment
Hide comment
@j3kyl

j3kyl Sep 29, 2018

lsp-enable-indentation as I turned it off lsp-java is now running smoothly! cant say why!

j3kyl commented Sep 29, 2018

lsp-enable-indentation as I turned it off lsp-java is now running smoothly! cant say why!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment