Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform-ls: Support commands for init and validate #3509

Merged
merged 2 commits into from
May 5, 2022

Conversation

psibi
Copy link
Member

@psibi psibi commented May 5, 2022

We implement two functions:

  • lsp-terraform-ls-validate
  • lsp-terraform-ls-init

The validate is most commonly used to verify the terraform files in the workspace directory.

We implement two functions:
- lsp-terraform-ls-validate
- lsp-terraform-ls-init

The validate is most commonly used to verify the terraform files in
the workspace directory.
@github-actions github-actions bot added the client One or more of lsp-mode language clients label May 5, 2022
@@ -93,6 +93,29 @@
:priority 1
:server-id 'tfmls))

(defun lsp-terraform-ls-validate ()
"Execute terraform validate on `default-directory'."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comment is not accurate - you are executing it over project root. default-directory is the current directory.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it was a comment from the old implementation. Fixed it, thanks!

@yyoncho yyoncho merged commit 6327359 into emacs-lsp:master May 5, 2022
@yyoncho
Copy link
Member

yyoncho commented May 5, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client One or more of lsp-mode language clients
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants