Skip to content

terraform: Reference counts using Code Lens - #3524

Merged
yyoncho merged 3 commits into
emacs-lsp:masterfrom
psibi:tf-refs
May 17, 2022
Merged

terraform: Reference counts using Code Lens#3524
yyoncho merged 3 commits into
emacs-lsp:masterfrom
psibi:tf-refs

Conversation

@psibi

@psibi psibi commented May 17, 2022

Copy link
Copy Markdown
Member

Hashicorp's language server implements an experimental opt-in code
lens to display the number of references to any root level block or
attribute.

This PR implements that feature.

@github-actions github-actions Bot added the client One or more of lsp-mode language clients label May 17, 2022
Hashicorp's language server implements an experimental opt-in code
lens to display the number of references to any root level block or
attribute.

This PR implements that feature.

@yyoncho yyoncho left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one minor nit.

Comment thread clients/lsp-terraform.el Outdated

(defun lsp-terraform-ls--custom-capabilities ()
"Construct custom capabilities for the language server."
(if lsp-terraform-ls-enable-show-reference

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: use when

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done!

@yyoncho
yyoncho merged commit 9131ab7 into emacs-lsp:master May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client One or more of lsp-mode language clients

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants