Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform: Reference counts using Code Lens #3524

Merged
merged 3 commits into from
May 17, 2022
Merged

Conversation

psibi
Copy link
Member

@psibi psibi commented May 17, 2022

Hashicorp's language server implements an experimental opt-in code
lens to display the number of references to any root level block or
attribute.

This PR implements that feature.

@github-actions github-actions bot added the client One or more of lsp-mode language clients label May 17, 2022
Hashicorp's language server implements an experimental opt-in code
lens to display the number of references to any root level block or
attribute.

This PR implements that feature.
Copy link
Member

@yyoncho yyoncho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one minor nit.


(defun lsp-terraform-ls--custom-capabilities ()
"Construct custom capabilities for the language server."
(if lsp-terraform-ls-enable-show-reference
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: use when

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done!

@yyoncho yyoncho merged commit 9131ab7 into emacs-lsp:master May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client One or more of lsp-mode language clients
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants