Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform: Implement new command to get discovered versions #3684

Merged
merged 4 commits into from
Aug 20, 2022
Merged

terraform: Implement new command to get discovered versions #3684

merged 4 commits into from
Aug 20, 2022

Conversation

psibi
Copy link
Member

@psibi psibi commented Aug 20, 2022

No description provided.

@github-actions github-actions bot added client One or more of lsp-mode language clients documentation labels Aug 20, 2022
yyoncho
yyoncho approved these changes Aug 20, 2022
View reviewed changes
Copy link
Member

@yyoncho yyoncho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, 2 minor nits:

clients/lsp-terraform.el Outdated Show resolved Hide resolved
clients/lsp-terraform.el Outdated Show resolved Hide resolved
@psibi psibi merged commit 480f804 into emacs-lsp:master Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyoncho yyoncho yyoncho approved these changes

@jcs090218 jcs090218 jcs090218 approved these changes

Assignees
No one assigned
Labels
client One or more of lsp-mode language clients documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@psibi @jcs090218 @yyoncho