Ignore bazel-* directories outside the root directory#4037
Merged
Conversation
# Why is this change necessary? [This previous PR](emacs-lsp#3768) added a default to ignore `bazel-*` directories that were children of the project root. However, the regex used does not ignore `bazel-*` directories elsewhere in the project repo. This can occur when a git submodule uses bazel. # What does this change do? Change the default value of `lsp-file-watch-ignored-directories` to ignore `bazel-*` directories wherever they are found in the repo, not just the root directory. # How is this change tested? I tested it locally by adding the new regex using the approach described [here](https://emacs-lsp.github.io/lsp-mode/page/file-watchers/) and I no longer see LSP warning that the number of file watches has exceeded its limit.
jcs090218
approved these changes
May 1, 2023
Contributor
Author
|
@jcs090218 I'm not sure how to interpret the error I'm getting in the failing CI/test: I also don't have access to a Windows machine. Any suggestions on how to proceed? |
Member
Don't worry about that! There is an incompatible error in the upstream Emacs' Windows snapshot. |
Contributor
Author
|
What's expected from me at this point? Will I need to rebase once the upstream snapshot is fixed? |
Member
Nope, you are all set! We regularly wait a day or two for other people to review it. :) |
Contributor
Author
|
Awesome, thanks for the fast response! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this change necessary?
This previous PR added a default to ignore
bazel-*directories that were children of the project root. However, the regex used does not ignorebazel-*directories elsewhere in the project repo. This can occur when a git submodule uses bazel.What does this change do?
Change the default value of
lsp-file-watch-ignored-directoriesto ignorebazel-*directories wherever they are found in the repo, not just the root directory.How is this change tested?
I tested it locally by adding the new regex using the approach described here and I no longer see LSP warning that the number of file watches has exceeded its limit.