Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add F# Language support #880

Merged
merged 5 commits into from Jun 13, 2019

Conversation

Projects
None yet
5 participants
@TOTBWF
Copy link
Contributor

commented Jun 13, 2019

This PR adds support for the F# language server: https://github.com/fsharp/FsAutoComplete.


(defun lsp-fsharp--make-launch-cmd ()
"Build the command required to launch fsautocomplete."
(if lsp-fsharp-server-install-dir (lsp-warn "Cannot locate fsautocomplete"))

This comment has been minimized.

Copy link
@baronfel

baronfel Jun 13, 2019

Suggested change
(if lsp-fsharp-server-install-dir (lsp-warn "Cannot locate fsautocomplete"))
(if lsp-fsharp-server-path (lsp-warn "Cannot locate fsautocomplete"))

should this be lsp-fsharp-server-path instead of lsp-fsharp-server-install-dir, since you renamed it a few commits ago?

This comment has been minimized.

Copy link
@TOTBWF

TOTBWF Jun 13, 2019

Author Contributor

🤦‍♂ Nice catch, fixed.

@yyoncho

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

Thank you and congrats for your first lsp-mode PR! 🎉

@yyoncho yyoncho merged commit 2afefb2 into emacs-lsp:master Jun 13, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kqr

This comment has been minimized.

Copy link

commented Jun 15, 2019

@TOTBWF Are you sure this is correct? It tests if lsp-fsharp-server-path is set, and if it is, it warns about it not being able to find lsp-fsharp-server. That sounds backwards to me.

@iNecas

This comment has been minimized.

Copy link
Contributor

commented Jun 15, 2019

@kqr I've hit this as well, seems just like an issue with if/unless, IMO this fixes the issue #889

@TOTBWF

This comment has been minimized.

Copy link
Contributor Author

commented Jun 15, 2019

Yeah, that PR fixes the issue. I totally brainfarted here, nice catch 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.