New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multi-line textDocument/hover #17

Closed
MaskRay opened this Issue Dec 22, 2017 · 5 comments

Comments

Projects
None yet
2 participants
@MaskRay
Member

MaskRay commented Dec 22, 2017

Currently textDocument/hover is implemented via

(setq-local eldoc-documentation-function #'lsp--on-hover)

For multi-line macro/struct/class declaration and comment support (see cquery-project/cquery#29 for cquery's ongoing support), this UI may be infeasible. We might need to provide an alternative UI.

@MaskRay

This comment has been minimized.

Show comment
Hide comment
@MaskRay
Member

MaskRay commented Dec 22, 2017

@sebastiencs

This comment has been minimized.

Show comment
Hide comment
@sebastiencs

sebastiencs Dec 23, 2017

Member

Yes there is the same issue with the Rust LS which sometimes returns documention of 15+ lines.
I was thinking to make it appear in a child frame

Member

sebastiencs commented Dec 23, 2017

Yes there is the same issue with the Rust LS which sometimes returns documention of 15+ lines.
I was thinking to make it appear in a child frame

@sebastiencs

This comment has been minimized.

Show comment
Hide comment
@sebastiencs

sebastiencs Dec 25, 2017

Member

@MaskRay See the commit 261c9a0

lsp-hover

Member

sebastiencs commented Dec 25, 2017

@MaskRay See the commit 261c9a0

lsp-hover

@MaskRay

This comment has been minimized.

Show comment
Hide comment
@MaskRay

MaskRay Dec 26, 2017

Member

Thanks!

In lsp-hover--extract, we may also need to extract MarkedString.language (cquery returns "text" instead of "markdown") and call (text-mode) instead of (markdown-view-mode) in lsp-hover--render-buffer

The issue is that

/*
 * comment
 */

may appear strangely when rendered as markdown.

@romix who may be interested.

Member

MaskRay commented Dec 26, 2017

Thanks!

In lsp-hover--extract, we may also need to extract MarkedString.language (cquery returns "text" instead of "markdown") and call (text-mode) instead of (markdown-view-mode) in lsp-hover--render-buffer

The issue is that

/*
 * comment
 */

may appear strangely when rendered as markdown.

@romix who may be interested.

MaskRay referenced this issue in cquery-project/cquery Dec 26, 2017

@MaskRay

This comment has been minimized.

Show comment
Hide comment
@MaskRay

MaskRay Dec 26, 2017

Member

@sebastiencs made some changes

Member

MaskRay commented Dec 26, 2017

@sebastiencs made some changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment