Skip to content

Commit

Permalink
; Add a new TODO item
Browse files Browse the repository at this point in the history
* etc/TODO: Add a new entry for :set-after.
* lisp/startup.el: Related comment.
  • Loading branch information
rgmorris committed Feb 21, 2017
1 parent bfd1afb commit 08c73cd
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
11 changes: 11 additions & 0 deletions etc/TODO
Expand Up @@ -968,6 +968,17 @@ addition, toolkit builds create their menu bars in toolkit-specific
parts of code, bypassing xdisp.c, so those parts need to be enhanced
with toolkit-specific code to display the menu bar right to left.

** Custom

*** Extend :set-after to also mean initialize after.
If defcustom A specifies :set-after '(B), then if a user customizes
both A and B, custom will set A after B. But if the user only customizes
A, then if B is already defined, it gets left at its original setting.
Instead, if B has not been customized it should be re-initialized
(on the assumption that the default value depends on A).
See the places where we manually call custom-reevaluate-setting,
such as for mail-host-address and user-mail-address in startup.el.

** ImageMagick support

*** image-type-header-regexps priorities the jpeg loader over the
Expand Down
2 changes: 1 addition & 1 deletion lisp/startup.el
Expand Up @@ -1298,7 +1298,7 @@ the `--debug-init' option to view a complete error backtrace."
;; Yes, this is ugly, but slightly less so than leaving
;; user-mail-address uninitialized during init file processing.
;; Perhaps we should make :set-after do something like this?
;; Ie, extend it to also mean (re)initialize-after.
;; Ie, extend it to also mean (re)initialize-after. See etc/TODO.
(equal user-mail-address
(let (mail-host-address)
(ignore-errors
Expand Down

0 comments on commit 08c73cd

Please sign in to comment.