Skip to content
This repository has been archived by the owner. It is now read-only.

Add auto-complete source and setup function #16

Closed
wants to merge 2 commits into from

Conversation

@NateEag
Copy link
Member

@NateEag NateEag commented Feb 4, 2014

This makes using the package easier for auto-complete users, as discussed in issue #11. My apologies for taking so long to do this.

The eval-after-load definition of the ac-source was based on tern's auto-complete source, since it was the first thing I found in my ELPA packages with an ac-source. If there's another approach you were thinking of, just let me know.

If you're happy with the way this works, I'll update the docs. Users should be able to just call

(payas/ac-setup)

in their php-mode hook.

This makes using the package easier for auto-complete users.
@ejmr
Copy link
Collaborator

@ejmr ejmr commented Feb 5, 2014

No need to apologize for the time. I really like the way this works and the implementation. IMO all it needs is a mention and example in the README for auto-complete users and then I'd be happy to merge this great addition.

@NateEag
Copy link
Member Author

@NateEag NateEag commented Feb 5, 2014

Excellent.

Today's probably going to be pretty busy, but I should be able to get to this by the end of the week.

@ejmr
Copy link
Collaborator

@ejmr ejmr commented Feb 7, 2014

Starting tomorrow I am going to be busy through Monday and it's really unlikely I will be able to merge until later that Monday. So please feel free to take your time over the weekend.

@NateEag
Copy link
Member Author

@NateEag NateEag commented Feb 8, 2014

Okay, I think this should do the job.

Let me know if you think anything needs editing.

@ejmr
Copy link
Collaborator

@ejmr ejmr commented Feb 9, 2014

Looks great to me. Merged as ec5923d.

Thanks again for this feature.

@ejmr ejmr closed this Feb 9, 2014
@NateEag
Copy link
Member Author

@NateEag NateEag commented Feb 9, 2014

You're very welcome.

Thanks for this package!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants