declare phpactor-executable as defcustom #108
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invoke action as if it was chosen from the context menu. Phpactor seems to have an issue with this rpc action invoked directly. As long as it's not fixed, this does the job.
Thanks Steve Purcell use of pcase instead of cl-case
Instead of the package's directory, copy the file to the user's .emacs.d directory and install it.
The term "Package" is ambiguous for both Lisp package (ELPA) and PHP package (Composer). Here we used Composer to try to set up Phpactor in a different directory with package.el, which meant Composer package.
Before the change, when phpactor-install-directory was NIL, it falls back to the directory of the Lisp package. However, there is no demand for that function, so we no longer have such an option.
The purpose of this change is to resolve the "package" ambiguity between Lisp and PHP.
Refactor phpactor-update
Add support for add_missing_assignments transform
add travis conf in order to run buttercup tests test phpactor installation test phpactor-get-working-dir (remove unused phpactor-working-dir variable) test phpactor--lisp-directory and add a fix for it
Add some tests using buttercup
upgrade to phpactor 0.12.0
That was a temporary solution for bug phpactor/phpactor#622
…tion Avoid use of context_menu rpc action for generate_accessor action
It was too soon to remove replace_file_source as it is sometimes invoked from a callback
Add function for those refactoring, making them accesible directly (ie not only via context menu)
ensime-mode has a similar implementation, which does not rely on tabulated mode and I liked the shorter implementation (grep-mode makes it easy to kill the buffer with a single keystroke). Besides, set-window-dedicated-p helps make the buffer sticky.
we're using phpactor-install-or-update now
this time, targeting develop
kermorgant
changed the title
kermorgant
force-pushed
the
feature/phpactor-executable-defcustom
branch
4 times, most recently
from
6e63624 to
4af92e5
Compare
Contributor
Author
|
Hi @zonuexe Following PR #106, I've made some attempts at replacing What do you think of this ? As a side effect, I've put aside things I did not understand, like making the variable buffer-local. Do you think that is still relevant ? |
kermorgant
force-pushed
the
feature/phpactor-executable-defcustom
branch
from
71438df to
95b612c
Compare
This allows user add extra behaviour (like code formatting) after buffer is modified by phpactor.
without working-directory, phpactor isn't very helpful.
also remove useless call to all-completions
By doing this, we are able to replace phpactor-find-executable function which is a bit more optimized. - update test - reevaluate phpactor-executable using setq (override defcustom), after composer install using hook
kermorgant
force-pushed
the
feature/phpactor-executable-defcustom
branch
from
95b612c to
d0111bd
Compare
kermorgant
changed the title
Contributor
Author
|
replaced by #118 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by doing this, we are able to replace phpactor-find-executable
function and optimize things a bit