diff --git a/phpactor.el b/phpactor.el index a22fa64..db7e2de 100644 --- a/phpactor.el +++ b/phpactor.el @@ -385,11 +385,16 @@ of GitHub.") (apply #'phpactor-action-dispatch (list :action (plist-get action :name) :parameters (plist-get action :parameters)))) actions)) -(cl-defun phpactor-action-open-file (&key path offset force_reload) +(cl-defun phpactor-action-open-file (&key path offset force_reload target) "Open file from Phpactor." (unless (and path offset) (user-error "Definition not found")) + ;; TODO: Implement other target: Phpactor\Extension\Rpc\Response\OpenFileResponse + ;; `target' expects "focused_window", "vsplit", "hsplit" and "new_tab" + (unless target + (setq target "focused_window")) + (if (fboundp 'xref-push-marker-stack) (xref-push-marker-stack) (with-no-warnings