Skip to content

Conversation

@zonuexe
Copy link
Member

@zonuexe zonuexe commented Jun 17, 2019

Add make test for testing.

@zonuexe zonuexe requested a review from kermorgant June 17, 2019 11:07
(describe "var: `phpactor-install-directory'"
(it "should have some value"
(display-warning 'buttercup (format "phpactor install folder is : %s" phpactor-install-directory))
(display-warning 'buttercup (format "phpactor install folder is : %s" phpactor-install-directory) :debug)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before

スクリーンショット 2019-06-17 20 07 57

After

スクリーンショット 2019-06-17 20 07 48

@kermorgant
Copy link
Contributor

Hi @zonuexe

On a new machine missin initial setup, I got this error while running make test

Opening directory: No such file or directory, /Users/mikaelkermorgant/src/phpactor.el/.cask

Running cask install fixed that.

So it looks good :-)

kermorgant
kermorgant previously approved these changes Jun 20, 2019
@zonuexe
Copy link
Member Author

zonuexe commented Jun 20, 2019

@kermorgant Thank you!

Copy link
Contributor

@kermorgant kermorgant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zonuexe zonuexe merged commit aacb70e into master Aug 3, 2019
@zonuexe zonuexe deleted the make-for-test branch August 3, 2019 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants