declare phpactor-executable as defcustom (take two) #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kermorgant
force-pushed
the
feature/phpactor-executable-defcustom-take2
branch
3 times, most recently
from
85f36e8 to
bd81306
Compare
kermorgant
force-pushed
the
feature/phpactor-executable-defcustom-take2
branch
from
bd81306 to
3063c33
Compare
By doing this, we are able to replace phpactor-find-executable function which is a bit more optimized as completion makes frequent use of it. - update test - reevaluate phpactor-executable using setq (override defcustom), after composer install using hook convert use of phpactor-executable function to use of variable apply change for completion too
kermorgant
force-pushed
the
feature/phpactor-executable-defcustom-take2
branch
from
3063c33 to
298c15b
Compare
This old implementation had an ambiguous behaviour It is now replaced by phpactor--find-executable which does only what its name implies
Contributor
Author
|
Hi @zonuexe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR #108 got its git history a bit messed so here's a new one.
By doing this, we are able to replace phpactor-find-executable
function which is a bit more optimized as completion makes frequent
use of it.
composer install using hook