Avoid use of context_menu rpc action for generate_accessor action #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kermorgant
force-pushed
the
generate-accessor-by-own-rpc-action
branch
from
0929bf0 to
ce42d24
Compare
That was a temporary solution for bug phpactor/phpactor#622
kermorgant
force-pushed
the
generate-accessor-by-own-rpc-action
branch
from
ce42d24 to
ae484ea
Compare
Contributor
Author
|
now that we have phpactor 0.12.0 in develop, this can be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of
context_menurpc action was a temporary solution for bug phpactor/phpactor#622This bug being fixed, we should be able to use
generate_accessordirectly on next release.