From 9229263c9cc28703b18c10596b448bc99906b04c Mon Sep 17 00:00:00 2001 From: USAMI Kenta Date: Fri, 8 Feb 2019 23:52:01 +0900 Subject: [PATCH] Fix (let default-directory) instead of setq it The default-directory must be set locally. People setting up Phpactor while editing will feel that behavior suspiciously. Since let binds variables only within that block, do not need to kill the buffer. --- phpactor.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/phpactor.el b/phpactor.el index b8daf6a..57bb9dd 100644 --- a/phpactor.el +++ b/phpactor.el @@ -99,8 +99,8 @@ (let ((package-folder (phpactor--get-package-directory)) (composer-executable (car (composer--find-executable)))) (unless composer-executable (error "`composer' not found")) - (setq default-directory package-folder) - (call-process composer-executable nil (get-buffer-create phpactor--buffer-name) nil "install" "--no-dev"))) + (let ((default-directory package-folder)) + (call-process composer-executable nil (get-buffer-create phpactor--buffer-name) nil "install" "--no-dev")))) (defun phpactor--get-package-directory () "Return the folder where phpactor.el is installed."