/no-littering

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dired-recent: theme dired-recent-directories-file #85

Closed
wants to merge 1 commit into
base: master
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@manuel-uberti @tarsius @Vifon
@manuel-uberti
Contributor

manuel-uberti commented Jun 28, 2018

dired-recent keeps a history of paths visited with Dired.

dired-recent-directories-file contains the above mentioned paths.
@tarsius

This comment has been minimized.

Show comment
Hide comment
@tarsius

tarsius Jun 28, 2018

Member

What's the format used in the file? If it's a s-expression, then the file should have an .el suffix.
Member

tarsius commented Jun 28, 2018

What's the format used in the file? If it's a s-expression, then the file should have an .el suffix.
@manuel-uberti

This comment has been minimized.

Show comment
Hide comment
@manuel-uberti

manuel-uberti Jun 28, 2018

Contributor

It's a list of strings. Let me ping @Vifon on this.
Contributor

manuel-uberti commented Jun 28, 2018

It's a list of strings. Let me ping @Vifon on this.
@Vifon

This comment has been minimized.

Show comment
Hide comment
@Vifon

Vifon Jun 28, 2018

Yes, it's a s-expression. Should I change the suffix upstream too?

Vifon commented Jun 28, 2018

Yes, it's a s-expression. Should I change the suffix upstream too?
@tarsius

This comment has been minimized.

Show comment
Hide comment
@tarsius

tarsius Jun 28, 2018

Member

Yes, it's a s-expression. Should I change the suffix upstream too?

It's only a no-littering-convention to do so and I would recommend against changing the default unless you also put some mechanism in place to rename an existing file.
Member

tarsius commented Jun 28, 2018

Yes, it's a s-expression. Should I change the suffix upstream too?

It's only a no-littering-convention to do so and I would recommend against changing the default unless you also put some mechanism in place to rename an existing file.
@manuel-uberti

This comment has been minimized.

Show comment
Hide comment
@manuel-uberti

manuel-uberti Jun 28, 2018

Contributor

Is there something I can do to help, then?
Contributor

manuel-uberti commented Jun 28, 2018

Is there something I can do to help, then?
@tarsius

This comment has been minimized.

Show comment
Hide comment
@tarsius

tarsius Jun 28, 2018

Member

Yes, update this pr to append the .el.
Member

tarsius commented Jun 28, 2018

Yes, update this pr to append the .el.
@manuel-uberti

This comment has been minimized.

Show comment
Hide comment
@manuel-uberti

manuel-uberti Jun 28, 2018

Contributor

Done :)
Contributor

manuel-uberti commented Jun 28, 2018

Done :)
@manuel-uberti

This comment has been minimized.

Show comment
Hide comment
@manuel-uberti

manuel-uberti Jul 4, 2018

Contributor

Any chance for this?
Contributor

manuel-uberti commented Jul 4, 2018

Any chance for this?
@manuel-uberti

This comment has been minimized.

Show comment
Hide comment
@manuel-uberti

manuel-uberti Jul 20, 2018

Contributor

Another friendly ping :)
Contributor

manuel-uberti commented Jul 20, 2018

Another friendly ping :)
@tarsius

This comment has been minimized.

Show comment
Hide comment
@tarsius

tarsius Jul 20, 2018

Member

Sorry I forgot about this -- I blame it on the kid. Most have gotten interrupted after checking out the pr but before responding. Anyway...

As per the conventions this file should be named "dired-recent-directories.el".
Member

tarsius commented Jul 20, 2018

Sorry I forgot about this -- I blame it on the kid. Most have gotten interrupted after checking out the pr but before responding. Anyway...

As per the conventions this file should be named "dired-recent-directories.el".
@manuel-uberti
dired-recent: theme dired-recent-directories-file 
This file contains the history of visited directories in Dired.

Add .el extension to dired-history file

Follow no-littering conventions in file naming
Verified
This commit was signed with a verified signature.
@manuel-uberti manuel-uberti Manuel Uberti
GPG key ID: 4E57A6C4CAA48F62 Learn about signing commits
ab3d405
@manuel-uberti

This comment has been minimized.

Show comment
Hide comment
@manuel-uberti

manuel-uberti Jul 21, 2018

Contributor

You're right, of course. Done! :)
Contributor

manuel-uberti commented Jul 21, 2018

You're right, of course. Done! :)

manuel-uberti added a commit to manuel-uberti/.emacs.d that referenced this pull request Jul 21, 2018

@manuel-uberti
Add dired-recent 
Disable for now. Pending this PR: emacscollective/no-littering#85
Verified
This commit was signed with a verified signature.
@manuel-uberti manuel-uberti Manuel Uberti
GPG key ID: 4E57A6C4CAA48F62 Learn about signing commits
39bb861
@tarsius

This comment has been minimized.

Show comment
Hide comment
@tarsius

tarsius Jul 23, 2018

Member

I have applied this. Thanks!

Please use a dedicated feature branch next time. See https://github.com/magit/magit/wiki/Dedicated-pull-request-branches.
Member

tarsius commented Jul 23, 2018

I have applied this. Thanks!

Please use a dedicated feature branch next time. See https://github.com/magit/magit/wiki/Dedicated-pull-request-branches.

@tarsius tarsius closed this Jul 23, 2018

@manuel-uberti

This comment has been minimized.

Show comment
Hide comment
@manuel-uberti

manuel-uberti Jul 24, 2018

Contributor

Sure thing. Thank you.
Contributor

manuel-uberti commented Jul 24, 2018

Sure thing. Thank you.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment