From 333802152ec7e51e50d0e66ca7fa9b3a54dac960 Mon Sep 17 00:00:00 2001 From: "Pedro A. Aranda Gutierrez" Date: Thu, 6 Oct 2022 18:25:29 +0200 Subject: [PATCH 1/3] Use (use-region-p) instead of mark-active --- move-text.el | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/move-text.el b/move-text.el index 111dcd9..729d5c4 100644 --- a/move-text.el +++ b/move-text.el @@ -66,13 +66,15 @@ Note: `region-beginning' and `region-end' are the reason why an \"The mark is not set now, so there is no region\" -We check `mark-active' to avoid calling -them when there's no region. -We use `prefix-numeric-value' to always return a number and simplify the functions +We check with `use-region-p' to avoid calling +them when there's no region or it is not appropriate +to act on it. + +We use `prefix-numeric-value' to return a number. " (list - (when mark-active (region-beginning)) ;; otherwise nil - (when mark-active (region-end)) + (when (use-region-p) (region-beginning)) ;; otherwise nil + (when (use-region-p) (region-end)) (prefix-numeric-value current-prefix-arg))) ;;;###autoload From 03d41f93aa62b854706f674da4d95ac520c121f2 Mon Sep 17 00:00:00 2001 From: "Pedro A. Aranda" Date: Mon, 4 Dec 2023 12:26:59 +0100 Subject: [PATCH 2/3] Use lexical-binding is available --- move-text.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/move-text.el b/move-text.el index 729d5c4..87e02c9 100644 --- a/move-text.el +++ b/move-text.el @@ -1,4 +1,4 @@ -;;; move-text.el --- Move current line or region with M-up or M-down. +;;; move-text.el --- Move current line or region with M-up or M-down. -*- lexical-binding: t; -*- ;; filename: move-text.el ;; Description: Move current line or region with M-up or M-down. From d62d94f6c43f567fd2fac189ee73c499fc04c822 Mon Sep 17 00:00:00 2001 From: "Pedro A. Aranda" Date: Mon, 4 Dec 2023 12:36:57 +0100 Subject: [PATCH 3/3] Yrying to fix cachix error in tests --- .github/workflows/test.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index a8f5562..daeab5c 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -19,12 +19,14 @@ jobs: - 27.1 - 27.2 - 28.1 + - 28.2 + - 29.1 - snapshot fail-fast: false steps: - uses: actions/checkout@v3 - name: Set up Emacs - uses: purcell/setup-emacs@v3.0 + uses: purcell/setup-emacs@master with: version: ${{ matrix.emacs_version }}