Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

speedbar integration seems to be working with a new definition of a s…

…peedbar function which was destroying frame management
  • Loading branch information...
commit b729a78ce8da486edae864ddd03de42e524af4ec 1 parent d49541c
burtonator authored
Showing with 23 additions and 7 deletions.
  1. +6 −0 CYCLE_PROPOSAL
  2. +1 −6 ecb-eshell.el
  3. +16 −1 ecb-speedbar.el
View
6 CYCLE_PROPOSAL
@@ -154,3 +154,9 @@ the buffers that are available for selection and then choose one.
could just do an:
- (defun ecb-cycle-create-profile(name buffers)
+
+- support the ability to compare two buffers to find out which should be higher
+ priority
+
+- support JIT buffer generation so that we aren't constantly regenerating
+ bufffers when they are actually hidden.
View
7 ecb-eshell.el
@@ -233,12 +233,7 @@ eshell is currently visible."
(select-window window)
- ;;this needs to be present under GNU Emacs or recenter will fail.
- (end-of-buffer)
-
- (recenter -2)
-
- (end-of-buffer))
+ (recenter -2))
(when display-errors
(error "Eshell not running or window not live"))))))
View
17 ecb-speedbar.el
@@ -111,6 +111,9 @@
;; that we HAVE to have the speedbar in a frame. If we try to run (speedbar)
;; when ecb-speedbar is active the ecb-frame will go away :(
+;; (speedbar-current-frame) doesn't seem to work right..
+;;
+
;;; Code:
(require 'ecb)
@@ -190,8 +193,16 @@ will/could break."
(speedbar-update-contents))))))
-(defun ecb-layout-function-20()
+(defun speedbar-find-file-in-frame(file)
+ "This will load FILE into the speedbar attached frame. If the file is being
+displayed in a different frame already, then raise that frame instead. Note
+that this is a reimplemntation of this for the ECB that does no frame selection"
+ (find-file file))
+
+(defun ecb-layout-function-20()
+ "ECB layout function for the speedbar."
+
(when ecb-compile-window-height
(ecb-split-ver (* -1 ecb-compile-window-height) t)
(setq ecb-compile-window (next-window)))
@@ -209,6 +220,7 @@ will/could break."
(defalias 'ecb-delete-other-windows-in-editwindow-20
'ecb-delete-other-windows-ecb-windows-right)
+
(defalias 'ecb-delete-window-in-editwindow-20
'ecb-delete-window-ecb-windows-right)
@@ -227,6 +239,9 @@ will/could break."
;;ecb-current-buffer-sync
(speedbar-disable-update)
+;;always stay in the current frame
+(setq speedbar-select-frame-method 0)
+
(provide 'ecb-speedbar)
;;; ecb-speedbar.el ends here
Please sign in to comment.
Something went wrong with that request. Please try again.