From 5d6a99e976e44d251f4666d7ddac0f42db8ee4fe Mon Sep 17 00:00:00 2001 From: D056966 Date: Mon, 20 Oct 2025 12:10:13 +0200 Subject: [PATCH 1/2] chore(ci): fix GH & NPM tokens --- .github/workflows/_init.yml | 1 - .github/workflows/_release.yml | 10 ++-------- .github/workflows/dev.yml | 6 +++--- .github/workflows/release.yml | 10 ++++------ 4 files changed, 9 insertions(+), 18 deletions(-) diff --git a/.github/workflows/_init.yml b/.github/workflows/_init.yml index 13649bb..a327e67 100644 --- a/.github/workflows/_init.yml +++ b/.github/workflows/_init.yml @@ -2,7 +2,6 @@ name: Initialize build on: workflow_call: - outputs: NODE_VERSION: value: ${{ jobs.init.outputs.NODE_VERSION }} diff --git a/.github/workflows/_release.yml b/.github/workflows/_release.yml index d86e245..38b6cf9 100644 --- a/.github/workflows/_release.yml +++ b/.github/workflows/_release.yml @@ -10,12 +10,6 @@ on: type: string required: true - secrets: - SEMANTIC_RELEASE_NPM_TOKEN: - required: true - SEMANTIC_RELEASE_GH_TOKEN: - required: true - jobs: test: name: Release package @@ -42,5 +36,5 @@ jobs: - name: Run release run: npm run release env: - NPM_TOKEN: ${{ secrets.SEMANTIC_RELEASE_NPM_TOKEN }} - GH_TOKEN: ${{ secrets.SEMANTIC_RELEASE_GH_TOKEN }} + GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + NPM_TOKEN: ${{ secrets.NPM_PUBLISHER_TOKEN }} diff --git a/.github/workflows/dev.yml b/.github/workflows/dev.yml index 251d40a..c1bcf92 100644 --- a/.github/workflows/dev.yml +++ b/.github/workflows/dev.yml @@ -2,9 +2,9 @@ name: Development on: push: - branches: [ '*', '*/*', '**', '!master', '!main' ] + branches: ['*', '*/*', '**', '!master', '!main'] pull_request: - branches: [ master, main ] + branches: [master, main] jobs: init: @@ -14,7 +14,7 @@ jobs: test: name: Test uses: ./.github/workflows/_test.yml - needs: [ init ] + needs: [init] with: NODE_VERSION: ${{ needs.init.outputs.NODE_VERSION }} NODE_CACHE_KEY: ${{ needs.init.outputs.NODE_CACHE_KEY }} diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 26d2eb8..a9050bd 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -2,7 +2,7 @@ name: Release on: push: - branches: [ master, main ] + branches: [master, main] jobs: init: @@ -12,7 +12,7 @@ jobs: test: name: Test uses: ./.github/workflows/_test.yml - needs: [ init ] + needs: [init] with: NODE_VERSION: ${{ needs.init.outputs.NODE_VERSION }} NODE_CACHE_KEY: ${{ needs.init.outputs.NODE_CACHE_KEY }} @@ -20,10 +20,8 @@ jobs: release: name: Release uses: ./.github/workflows/_release.yml - needs: [ init, test ] + needs: [init, test] with: NODE_VERSION: ${{ needs.init.outputs.NODE_VERSION }} NODE_CACHE_KEY: ${{ needs.init.outputs.NODE_CACHE_KEY }} - secrets: - SEMANTIC_RELEASE_NPM_TOKEN: ${{ secrets.SEMANTIC_RELEASE_NPM_TOKEN }} - SEMANTIC_RELEASE_GH_TOKEN: ${{ secrets.SEMANTIC_RELEASE_GH_TOKEN }} + secrets: inherit From 6ba445c9042dc145efdd0812f082030b118bcb82 Mon Sep 17 00:00:00 2001 From: D056966 Date: Mon, 20 Oct 2025 12:11:57 +0200 Subject: [PATCH 2/2] don't trigger `push` for PRs --- .github/workflows/dev.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/dev.yml b/.github/workflows/dev.yml index c1bcf92..0e17de7 100644 --- a/.github/workflows/dev.yml +++ b/.github/workflows/dev.yml @@ -1,8 +1,6 @@ name: Development on: - push: - branches: ['*', '*/*', '**', '!master', '!main'] pull_request: branches: [master, main]