Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(plugins): Adding embark-mythx to plugins page #1572

Merged
merged 1 commit into from May 3, 2019

Conversation

semuelle
Copy link
Contributor

@semuelle semuelle commented May 2, 2019

No description provided.

Copy link
Collaborator

@emizzle emizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @semuelle, awesome work!

Copy link
Collaborator

@emizzle emizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, actually I'm going to hold off approval until we are sure the PR title follows the conventions. Will let @PascalPrecht jump in here.

@emizzle emizzle self-requested a review May 3, 2019 01:43
@0x-r4bbit
Copy link
Contributor

Thanks @semuelle for updating your commits. For the future, as we hope you'll contribute again :), you can just force push into your PR branch after you've changed your commits. There's no need to open new PRs :)

@0x-r4bbit 0x-r4bbit merged commit 0991803 into embarklabs:master May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants