Fix hanging tests when using a wrong node #556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iurimatias
approved these changes
Jun 19, 2018
emizzle
reviewed
Jun 19, 2018
| req.on('upgrade', (_res, _socket, _head) => { | ||
| next(); | ||
| }); | ||
| const {host, port, type, protocol} = self.contractsConfig.deployment; |
Collaborator
There was a problem hiding this comment.
Should we handle the case where protocol is not specified in the config, ie default to http? Or possibly amend the default contracts config options to include "protocol": "http"?
Collaborator
Author
There was a problem hiding this comment.
pingEndpoint handles the case where protocol is undefined, but maybe setting as a default in config.js would be a good idea
| if (!protocol) { | ||
| protocol = (this.simOptions.type === "rpc") ? 'http' : 'ws'; | ||
| } | ||
| const endpoint = `${protocol}://${host}:${port}`; |
Collaborator
There was a problem hiding this comment.
Could also use utils.buildUrl or utils.buildUrlFromConfig.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the case where you try to test specifying a non available node or the node is off.
Moved the pingEndpoint function to utils so that I could use it in tests too.