Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to build with cargo_metadata 0.10 #10

Closed
sdroege opened this issue Jul 28, 2020 · 5 comments · Fixed by #11
Closed

Fails to build with cargo_metadata 0.10 #10

sdroege opened this issue Jul 28, 2020 · 5 comments · Fixed by #11
Labels
bug Something isn't working

Comments

@sdroege
Copy link

sdroege commented Jul 28, 2020

60c3740 worked around an accidental semver breakage in cargo_metadata 0.10.1, which was yanked in the meantime and re-released as 0.11.

This means that now krates fails to build against cargo_metadata 0.10.0. Either needs to be updated to 0.11 or 60c3740 has to be reverted.

If semver or any cargo_metadata type is part of the public API of this crate then the former would require updating the krates version to 0.4.

@sdroege sdroege added the bug Something isn't working label Jul 28, 2020
@sdroege
Copy link
Author

sdroege commented Jul 28, 2020

Thanks for the fast response. Unless you yank 0.3.1 of krates this will nonetheless break everything that currently depends on krates 0.3 and is not updated yet. Please either yank it, or upload a 0.3.2 that simply downgrades the semver dependency to 0.9.

@Jake-Shadle
Copy link
Member

Yah, I'll just yank 0.3.1. This was rather annoying, but I do enjoy the irony of this being because of the semver crate.

@sdroege
Copy link
Author

sdroege commented Jul 28, 2020

Indeed :) Thanks again!

@sdroege
Copy link
Author

sdroege commented Jul 28, 2020

And the very same problem in extension also exists with cargo-deny 0.7.1. Want me to create an issue for that or will you take care of that?

@Jake-Shadle
Copy link
Member

There is an existing issue I just reopened, thanks though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants