Fix line algorithm implementation #13
Merged
Conversation
Thanks for taking a crack at this! A couple of things:
|
I've added tests for each octant. I'm not sure if its the best way to test things, but it should catch regressions. |
Looks good! I like your approach to the testing, much better than mine as it actually checks the line. Thanks for fixing the lines! |
dbbd91b
into
embedded-graphics:master
1 check passed
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This implements the Bresenham's line algorithm from the wikipedia page with some slight modifications.
fixes #11