Navigation Menu

Skip to content

Commit

Permalink
Remove support for modals
Browse files Browse the repository at this point in the history
These relied on view support removed in Ember. Consider ember-elsewhere
instead.
  • Loading branch information
wagenet committed Jul 28, 2016
1 parent fd7ffa6 commit a979937
Show file tree
Hide file tree
Showing 37 changed files with 2 additions and 981 deletions.
23 changes: 0 additions & 23 deletions addon/components/lf-overlay.js

This file was deleted.

102 changes: 0 additions & 102 deletions addon/components/liquid-modal.js

This file was deleted.

96 changes: 0 additions & 96 deletions addon/components/lm-container.js

This file was deleted.

18 changes: 0 additions & 18 deletions addon/constrainables.js
Expand Up @@ -49,24 +49,6 @@ export default {
},
parentElement: {},
firstTime: {},
oldModalComponent: {
reversesTo: 'newModalComponent',
accessor: function(conditions) {
var value = versionValue(conditions, 1);
if (value) {
return [value.name];
}
}
},
newModalComponent: {
reversesTo: 'oldModalComponent',
accessor: function(conditions) {
var value = versionValue(conditions, 0);
if (value) {
return [value.name];
}
}
},
media: {}
};

Expand Down
8 changes: 0 additions & 8 deletions addon/dsl.js
Expand Up @@ -121,14 +121,6 @@ export default class DSL {
return new Constraint('outletName', names);
}

toModal(matcher) {
return new Constraint('newModalComponent', matcher);
}

fromModal(matcher) {
return new Constraint('oldModalComponent', matcher);
}

media(query) {
return new Constraint('media', function() {
return window.matchMedia(query).matches;
Expand Down
7 changes: 0 additions & 7 deletions addon/ember-internals.js
Expand Up @@ -7,7 +7,6 @@ import Ember from "ember";
var emberRequire = Ember.__loader.require;
var internal = emberRequire('htmlbars-runtime').internal;
var registerKeyword = emberRequire('ember-htmlbars/keywords').registerKeyword;
var legacyViewKeyword = emberRequire('ember-htmlbars/keywords/view').default;
var _Stream = Ember.__loader.registry['ember-metal/streams/stream'] ? emberRequire('ember-metal/streams/stream') : emberRequire('ember-htmlbars/streams/stream');
var BasicStream = _Stream.default;
var Stream = _Stream.Stream;
Expand Down Expand Up @@ -134,12 +133,6 @@ export function registerKeywords() {
return true;
}
});

// This gives us a non-deprecated view keyword so we can continue to
// ship the old liquid-modal template for now without breaking
// people's apps. liquid-modal itself is deprecated and will ship in
// 1.13 but not 2.0.
registerKeyword('lf-vue', legacyViewKeyword);
}

export function getComponentFactory(owner, name) {
Expand Down
16 changes: 0 additions & 16 deletions addon/internal-rules.js

This file was deleted.

79 changes: 0 additions & 79 deletions addon/modal.js

This file was deleted.

2 comments on commit a979937

@mattmcginnis
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an easy way to access the old documentation for liquid modals?

@ef4
Copy link
Collaborator

@ef4 ef4 commented on a979937 Oct 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not online. Versioned docs would be great but we don't have them right now. Your best bet at the moment is probably to just boot up the docs app yourself locally (which isn't hard to do if you're already used to running ember apps):

  1. git clone https://github.com/ember-animation/liquid-fire
  2. cd liquid-fire
  3. git checkout v0.24.1
  4. npm install; bower install; ember s
  5. View http://localhost:4200

Please sign in to comment.