New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getOwner container deprecations for Canary. #388

Merged
merged 2 commits into from Nov 14, 2015

Conversation

Projects
None yet
2 participants
@rwjblue
Contributor

rwjblue commented Nov 14, 2015

As of Ember 2.3, using this.container from within an instance that is looked up from the container will issue a deprecation warning suggesting that you should refactor away from the private this.container usage to the new public API for using container/registry features (Ember.getOwner(this)).

This change pulls in the ember-getowner-polyfill to allow us to use getOwner on all Ember versions (tested back to 1.10 in that addon's CI).

Fix getOwner container deprecations for Canary.
As of Ember 2.3, using `this.container` from within an instance that is
looked up from the container will issue a deprecation warning suggesting
that you should refactor away from the private `this.container` usage to
the new public API for using container/registry features
(`Ember.getOwner(this)`).

This change pulls in the `ember-getowner-polyfill` to allow us to use
`getOwner` on all Ember versions (tested back to 1.10 in that addon's
CI).
@rwjblue

This comment has been minimized.

Show comment
Hide comment
@rwjblue

rwjblue Nov 14, 2015

Contributor

This fixes canary in CI, but there is still an issue with beta (unrelated to the ember-container-inject-owner feature that this is operating on).

Contributor

rwjblue commented Nov 14, 2015

This fixes canary in CI, but there is still an issue with beta (unrelated to the ember-container-inject-owner feature that this is operating on).

@rwjblue

This comment has been minimized.

Show comment
Hide comment
@rwjblue

rwjblue Nov 14, 2015

Contributor

I just pushed another commit to fix the issue with the beta build.

Contributor

rwjblue commented Nov 14, 2015

I just pushed another commit to fix the issue with the beta build.

@rwjblue

This comment has been minimized.

Show comment
Hide comment
@rwjblue

rwjblue Nov 14, 2015

Contributor

Boom. How about that 📗.

Contributor

rwjblue commented Nov 14, 2015

Boom. How about that 📗.

@rwjblue rwjblue referenced this pull request Nov 14, 2015

Closed

ember-container-inject-owner - Checklist #12555

8 of 8 tasks complete
@ef4

This comment has been minimized.

Show comment
Hide comment
@ef4

ef4 Nov 14, 2015

Collaborator

Beautiful. 👏

Collaborator

ef4 commented Nov 14, 2015

Beautiful. 👏

ef4 added a commit that referenced this pull request Nov 14, 2015

Merge pull request #388 from rwjblue/handle-getowner
Fix getOwner container deprecations for Canary.

@ef4 ef4 merged commit fef1837 into ember-animation:master Nov 14, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rwjblue rwjblue deleted the rwjblue:handle-getowner branch Nov 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment