Template coverage

[mukilane]

In continuation of #103

[mukilane]

@rwjblue #103 seemed dormat for quite a while, so I took it up. Basically I'd,

• Rebased to master and refactored the code a bit.
• Handled branches and attribute nodes.
• Handled actions
• Added some tests
• Added include/exclude option

There are still some areas where some pointers would be helpful.

• How to introduce this change ? I've added it as an opt-in configuration templateCoverage to prevent breaking users' existing thresholds in CI.
• While this works for app, somehow it is not working for addon. The plugin in not invoked for addon files (though it is called for tests files). Am I missing anything here ?

Can you help me out ?

Coverage report of the test component

[mukilane]

@rwjblue / @kategengler Any inputs on this ?

[gabrielcsapo]

This would be great to merge!

[kategengler]

I definitely want this feature. However, I don't know enough about this feature to evaluate the PR, maybe @rwjblue or @thoov (as a recent contributor), could review?

[gabrielcsapo]

More than happy to rebase this PR or open up one with the fixes @thoov @rwjblue if needed

[Gorzas]

Can I help in anyway? This could be handy for us too.

[tehhowch]

bump - Really looking forward to this!

[camerondubas]

Also very interested in this feature! If needed, I'm happy to help get it over the finish line.

[RobbieTheWagner]

@kategengler I think we should consider just merging this and hoping for the best. I don't think anyone with deep knowledge of this work is around and able to review. Thoughts?

[RobbieTheWagner]

To note, tests don't seem to have run here, so we need to make sure CI runs and passes before merging.

[kategengler]

@kategengler I think we should consider just merging this and hoping for the best. I don't think anyone with deep knowledge of this work is around and able to review. Thoughts?

To me, this is a scary statement because this means there's also nobody around with knowledge of this work to fix any bugs once released. I could be convinced if someone tries it out on a few apps, though.

[mukilane]

@kategengler I think we should consider just merging this and hoping for the best. I don't think anyone with deep knowledge of this work is around and able to review. Thoughts?

To me, this is a scary statement because this means there's also nobody around with knowledge of this work to fix any bugs once released. I could be convinced if someone tries it out on a few apps, though.

@kategengler

I haven't had the chance to revist this so far.

I'll revist it again, this weekend, and maybe I can find what I am missing while running for addons.

Also, I need some clarity on how we will release this. Opt-in seems sensible, so I'll proceed with that. If needed we can change that.

I have few real world apps, engines and addons. So will share any findings with that as well.

[tehhowch]

Definitely opt-in at first, and then in the next major version or two, after refinement, make it opt-out. My team's apps would need a little work to get upgraded to the version this lands in, but after that I'd happily help report issues / attempt fixes.

[vstefanovic97]

Any updates on this?