New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some sort of feedback when --verbose=false #276

Closed
achambers opened this Issue Oct 28, 2015 · 9 comments

Comments

Projects
None yet
4 participants
@achambers
Copy link
Member

achambers commented Oct 28, 2015

Now that we have turned off the logging unless --verbose is set some people are feeling like they are missing some form of feedback that something is happening.

Might be worth thinking about adding some sort of simple spinner (maybe like ember install uses) when the verbose flag is false.

@ghedamat

This comment has been minimized.

Copy link
Collaborator

ghedamat commented Oct 28, 2015

or maybe just a couple of simple

starting deploy...
deploy done!

messages?

@achambers

This comment has been minimized.

Copy link
Member

achambers commented Oct 28, 2015

Sure...Anything....It might be nice to use https://www.npmjs.com/package/pleasant-progress like ember-cli does to give a perception of something actively happening.

Dunno...It's just feedback I've been given based on the new "no output by default". While the general inspiration is "if there is no output then everything is good" maybe something small like this might be helpful.

@ghedamat

This comment has been minimized.

Copy link
Collaborator

ghedamat commented Oct 28, 2015

understood

will see if I can do something on plane :D

@jrowlingson

This comment has been minimized.

Copy link
Contributor

jrowlingson commented Oct 28, 2015

+1 - I spent more time than I should have last night trying to figure out why my plugin was not logging anything.

@ghedamat

This comment has been minimized.

Copy link
Collaborator

ghedamat commented Oct 28, 2015

@jrowlingson you're talking about a plugin you're writing right?

for that we definitely need to add mention of the new verbose option
on the docs

http://ember-cli.github.io/ember-cli-deploy/docs/v0.5.x/writing-a-plugin/

I'll see if I can get to that as well while I fly to embercamp

@achambers

This comment has been minimized.

Copy link
Member

achambers commented Oct 28, 2015

Thanks @ghedamat.

@jrowlingson

This comment has been minimized.

Copy link
Contributor

jrowlingson commented Oct 28, 2015

@ghedamat Yes, I have started working on the github plugin.

@ghedamat

This comment has been minimized.

Copy link
Collaborator

ghedamat commented Oct 28, 2015

@jrowlingson glad to hear!

you probably figured it out already but you can do this
https://github.com/ember-cli-deploy/ember-cli-deploy-redis/blob/master/index.js#L69
to make the log always show

otherwise pass the --verbose option.

feel free to reach out on #ember-cli-deploy on the ember slack if you need help!

@ghedamat ghedamat referenced this issue Oct 29, 2015

Merged

display progress notification during deploy #280

4 of 5 tasks complete

@lukemelia lukemelia added the 0.6.x label Jan 7, 2016

@lukemelia lukemelia added this to the 0.6.x milestone Jan 7, 2016

@lukemelia

This comment has been minimized.

Copy link
Contributor

lukemelia commented Jan 22, 2016

Closed by #280

@lukemelia lukemelia closed this Jan 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment