This repository was archived by the owner on Jan 30, 2023. It is now read-only.
Refactor request logic to avoid duplicate calls/Refactor tests #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to call `options()` twice, but avoiding that extra work isn't too hard. Also adds tests to verify that the method is only called once per type of request method called (`request` and `raw`, respectively). Closes #122
alexlafroscia
force-pushed
the
avoid-calling-options-method-twice
branch
from
f2b288b to
88eb8bf
Compare
alexlafroscia
changed the title
Collaborator
Author
|
@rwjblue would you mind taking a look real quick, before I merge this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to call
options()twice, but avoiding that extra work isn't too hard. Also adds tests to verify that the method is only called once per type of request method called (requestandraw, respectively).Closes #122
Also adds a bunch of test refactoring to make them a little bit cleaner and to take advantage of some of the Mocha and Chai features that we're not yet using.