New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Windows Experience #1558

Closed
stefanpenner opened this Issue Aug 4, 2014 · 85 comments

Comments

Projects
None yet
@stefanpenner
Contributor

stefanpenner commented Aug 4, 2014

Please note, this is a live document. Comments below will be used to incorporate ideas into this issue and then subsequently removed.


Very few of the main ember-cli contributors are also windows users. This results in some poor windows experiences as no-one is dog-fooding there issues.

It is also true some performance issues exist in unix systems but solutions are currently WIP (with order of magnitude improvements so far). These solutions may or may not translate to improvements in windows.

Problems

this is often the result of editor/search indexing/virus scanner/defending indexing tmp directories. Broccoli relies on fast disk access, and often quickly changing files. Anything that interferes with this can result in slowdown, Progress but blocked on: broccolijs/node-symlink-or-copy#1

  • stability
    • get CI setup
    • get CI passing (we need to upgrade to a premium account so we don't timeout)

our active development does not occur on windows, and neither does our CI run on windows so detecting regressions quickly is basically non-existent before releases.

  • time

As ember-cli is a labour of love (no corporate sponsorship) time invested is nearly entirely evenings/weekends. Because of this, most contributions are really dog-fooding the developers own pet peeves. Coupling this with far fewer windows contributors results is far less time spent improving the lives of our windows folk.

Some Solutions

  • active windows contributor for ember-cli
  • active windows contributor for broccoli
  • maybe sponsorship of @rwjblue, @joliss or some other eager and passionate individual to work on this problem?
  • broccoli may want to consider using collide-able files names (stability)

Some tasks

  • documentation for windows specific issues/work-arounds
  • test suite should once again work on windows
  • some easy way for non-windows contributors to quickly test windows (maybe via some pre-configured VM all ready to go + some legally acquired windows licenses)
  • ember-cli test suite should once again work on windows (it may or may not.. this is part of the problem)
  • continuous integration on windows ?
  • test suite actually runs on windows (git-bash)
  • test suite actually runs on windows (without git-bash)
  • test suite largely working
  • test suite green on local vm
  • test suite green on CI
  • someone to work extend the current WIP symlinking approach to windows.
  • fix usage on cygwin #1812
  • fix: #1292
  • fix: #1864 (comment)

Once the symlink refactoring (broccolijs/broccoli#179) is finished & released, it will provide a great speed-up on Unix. But at the moment we're just falling back to copying on Windows, so performance isn't improving there. We should probably try to make symlinks or junctions work on Windows as much as possible, even if the exact code might need to cover some edge-cases. The relevant code is node-symlink-or-copy/index.js#L14-L17.
-- @joliss

Sponsorship

I really want to discourage us from thinking this is the only way to solve this problem, but without more windows contributors it is hard to find the time ourselves to accomplish this without having our day-time employers giving us time.

If sponsorship is made available please remember that this gets quite tricky, as we all know quoting timelines is no developers speciality. And as such putting a single price-tag on improved windows quality is essentially impossible. But it may enable some improvements.

Another form of sponsorship could be for an entity to give one of there own developers some time to help work on the above tasks^

Call for contributions

If any windows users (or users with time to help contribute improvements to our windows users) have time, but feel they need some guidance or help don't hesitate to reach out.

@ccoenen

This comment has been minimized.

Show comment
Hide comment
@ccoenen

ccoenen Aug 5, 2014

Contributor

I would be willing to work with master instead of tagged versions on my machine. Maybe i can catch a bug or two that way.

A section "how to work/test/develop with master" might be helpful for CONTRIBUTING.md.

Contributor

ccoenen commented Aug 5, 2014

I would be willing to work with master instead of tagged versions on my machine. Maybe i can catch a bug or two that way.

A section "how to work/test/develop with master" might be helpful for CONTRIBUTING.md.

@BryanCrotaz

This comment has been minimized.

Show comment
Hide comment
@BryanCrotaz

BryanCrotaz Aug 5, 2014

I'd be happy for my company to sponsor the CI server.

We have a Bamboo CI system with builds in the Amazon EC2 cloud. It would be easy to set up a build plan for bamboo to build and test.

BryanCrotaz commented Aug 5, 2014

I'd be happy for my company to sponsor the CI server.

We have a Bamboo CI system with builds in the Amazon EC2 cloud. It would be easy to set up a build plan for bamboo to build and test.

@rwjblue

This comment has been minimized.

Show comment
Hide comment
@rwjblue

rwjblue Aug 5, 2014

Contributor

@ccoenen - The instructions for using/testing on master of ember-cli are in this project's README (they don't go into gh-pages as they are targeted specifically at developers OF ember-cli not consumers of it).

Contributor

rwjblue commented Aug 5, 2014

@ccoenen - The instructions for using/testing on master of ember-cli are in this project's README (they don't go into gh-pages as they are targeted specifically at developers OF ember-cli not consumers of it).

@BryanCrotaz

This comment has been minimized.

Show comment
Hide comment
@BryanCrotaz

BryanCrotaz Aug 5, 2014

I've had problems getting npm link to work on Windows. What's the recommended way to bring master into a Windows machine in order to test?

BryanCrotaz commented Aug 5, 2014

I've had problems getting npm link to work on Windows. What's the recommended way to bring master into a Windows machine in order to test?

@BryanCrotaz

This comment has been minimized.

Show comment
Hide comment
@BryanCrotaz

BryanCrotaz Aug 5, 2014

If a test suite passes or fails in CI, where should the results be posted?

BryanCrotaz commented Aug 5, 2014

If a test suite passes or fails in CI, where should the results be posted?

@BryanCrotaz

This comment has been minimized.

Show comment
Hide comment
@BryanCrotaz

BryanCrotaz Aug 5, 2014

in fact I can't find where the current or historic linux test results are posted

BryanCrotaz commented Aug 5, 2014

in fact I can't find where the current or historic linux test results are posted

@stefanpenner

This comment has been minimized.

Show comment
Hide comment
@stefanpenner

stefanpenner Aug 5, 2014

Contributor

@Twinkletoes our current CI: https://travis-ci.org/stefanpenner/ember-cli
I would love to also have a windows CI, what can we do to move forward on a windows CI server?

Contributor

stefanpenner commented Aug 5, 2014

@Twinkletoes our current CI: https://travis-ci.org/stefanpenner/ember-cli
I would love to also have a windows CI, what can we do to move forward on a windows CI server?

@BryanCrotaz

This comment has been minimized.

Show comment
Hide comment
@BryanCrotaz

BryanCrotaz Aug 5, 2014

Happy to set on up in the next week or so. What we need is a .bat file in the repo (I usually create a buildscript folder) which makes no assumptions about what's preinstalled.

So it should:
install node (possibly iterating multiple versions)
install npm
build
test
report result back to github

The build plan will be set up to:
check out git repo
run buildscripts/build.bat

We can run it on a webhook from github, and it can auto discover branches and test those too.

BryanCrotaz commented Aug 5, 2014

Happy to set on up in the next week or so. What we need is a .bat file in the repo (I usually create a buildscript folder) which makes no assumptions about what's preinstalled.

So it should:
install node (possibly iterating multiple versions)
install npm
build
test
report result back to github

The build plan will be set up to:
check out git repo
run buildscripts/build.bat

We can run it on a webhook from github, and it can auto discover branches and test those too.

@stefanpenner

This comment has been minimized.

Show comment
Hide comment
@stefanpenner

stefanpenner Aug 5, 2014

Contributor

@ccoenen the Readme outlines some tips for development. https://github.com/stefanpenner/ember-cli#development-hints. It may be that the tips are leaving out important windows details. Maybe you could give that flow a try and fill in any windows specific details that may be missing?

I (and likely our windows users) would be appreciative of any help you can offer. On-going usage of ember-cli#master on windows will likely catch bugs early and prevent us from introducing easily preventable regressions

Let me know if I can help you in any way.

Contributor

stefanpenner commented Aug 5, 2014

@ccoenen the Readme outlines some tips for development. https://github.com/stefanpenner/ember-cli#development-hints. It may be that the tips are leaving out important windows details. Maybe you could give that flow a try and fill in any windows specific details that may be missing?

I (and likely our windows users) would be appreciative of any help you can offer. On-going usage of ember-cli#master on windows will likely catch bugs early and prevent us from introducing easily preventable regressions

Let me know if I can help you in any way.

@BryanCrotaz

This comment has been minimized.

Show comment
Hide comment
@BryanCrotaz

BryanCrotaz Aug 5, 2014

by making no assumptions, the test script will also test the "out of the box" experience of ember-cli for new developers, ensuring that no extra libraries are required

BryanCrotaz commented Aug 5, 2014

by making no assumptions, the test script will also test the "out of the box" experience of ember-cli for new developers, ensuring that no extra libraries are required

@BryanCrotaz

This comment has been minimized.

Show comment
Hide comment
@BryanCrotaz

BryanCrotaz Aug 5, 2014

Found out how to log build pass/fail to github but can't see how to show
logs and which tests passed/failed. Is it best to put these on a wiki page
for each build?

On 5 August 2014 15:31, Stefan Penner notifications@github.com wrote:

@ccoenen https://github.com/ccoenen the Readme outlines some tips for
development. https://github.com/stefanpenner/ember-cli#development-hints.
It may be that the tips are leaving out important windows details. Maybe
you could give that flow a try and fill in any windows specific details
that may be missing?

I (and likely our windows users) would be appreciative of any help you can
offer. On-going usage of ember-cli#master on windows will likely catch bugs
early and prevent us from introducing easily preventable regressions

Let me know if I can help you in any way.


Reply to this email directly or view it on GitHub
#1558 (comment)
.

Bryan Crotaz
Managing Director
Silver Curve

BryanCrotaz commented Aug 5, 2014

Found out how to log build pass/fail to github but can't see how to show
logs and which tests passed/failed. Is it best to put these on a wiki page
for each build?

On 5 August 2014 15:31, Stefan Penner notifications@github.com wrote:

@ccoenen https://github.com/ccoenen the Readme outlines some tips for
development. https://github.com/stefanpenner/ember-cli#development-hints.
It may be that the tips are leaving out important windows details. Maybe
you could give that flow a try and fill in any windows specific details
that may be missing?

I (and likely our windows users) would be appreciative of any help you can
offer. On-going usage of ember-cli#master on windows will likely catch bugs
early and prevent us from introducing easily preventable regressions

Let me know if I can help you in any way.


Reply to this email directly or view it on GitHub
#1558 (comment)
.

Bryan Crotaz
Managing Director
Silver Curve

@stefanpenner

This comment has been minimized.

Show comment
Hide comment
@stefanpenner

stefanpenner Aug 5, 2014

Contributor

@Twinkletoes that would be fantastic

for reference our travis configuration is located at: https://github.com/stefanpenner/ember-cli/blob/master/.travis.yml the key piece is likely npm run-script test-all which should run all our unit/integration and acceptance level tests

Is it possible to have this CI server run for pull requests? This way we can prevent regressions before they enter mainstream.

Another idea (and task) for windows development might be to provide a dev/Vagrantfile for us linux/osx users so we can quickly jump into a Windows environment configured to development and test ember-cli

Contributor

stefanpenner commented Aug 5, 2014

@Twinkletoes that would be fantastic

for reference our travis configuration is located at: https://github.com/stefanpenner/ember-cli/blob/master/.travis.yml the key piece is likely npm run-script test-all which should run all our unit/integration and acceptance level tests

Is it possible to have this CI server run for pull requests? This way we can prevent regressions before they enter mainstream.

Another idea (and task) for windows development might be to provide a dev/Vagrantfile for us linux/osx users so we can quickly jump into a Windows environment configured to development and test ember-cli

@BryanCrotaz

This comment has been minimized.

Show comment
Hide comment
@BryanCrotaz

BryanCrotaz Aug 5, 2014

what's a vagrant file?

Not sure if I can set it up to run pull-requests. Let's start with main and
branches and see where we go from there.

We could always bring a pull request into a branch first then merge down
once tested.

On 5 August 2014 15:34, Stefan Penner notifications@github.com wrote:

@Twinkletoes https://github.com/Twinkletoes that would be fantastic

for reference our travis configuration is located at:
https://github.com/stefanpenner/ember-cli/blob/master/.travis.yml the key
piece is likely npm run-script test-all which should run all our
unit/integration and acceptance level tests

Is it possible to have this CI server run for pull requests? This way we
can prevent regressions before they enter mainstream.

Another idea (and task) for windows development might be to provide a
dev/Vagrantfile for us linux/osx users so we can quickly jump into a
Windows environment configured to development and test ember-cli


Reply to this email directly or view it on GitHub
#1558 (comment)
.

Bryan Crotaz
Managing Director
Silver Curve

BryanCrotaz commented Aug 5, 2014

what's a vagrant file?

Not sure if I can set it up to run pull-requests. Let's start with main and
branches and see where we go from there.

We could always bring a pull request into a branch first then merge down
once tested.

On 5 August 2014 15:34, Stefan Penner notifications@github.com wrote:

@Twinkletoes https://github.com/Twinkletoes that would be fantastic

for reference our travis configuration is located at:
https://github.com/stefanpenner/ember-cli/blob/master/.travis.yml the key
piece is likely npm run-script test-all which should run all our
unit/integration and acceptance level tests

Is it possible to have this CI server run for pull requests? This way we
can prevent regressions before they enter mainstream.

Another idea (and task) for windows development might be to provide a
dev/Vagrantfile for us linux/osx users so we can quickly jump into a
Windows environment configured to development and test ember-cli


Reply to this email directly or view it on GitHub
#1558 (comment)
.

Bryan Crotaz
Managing Director
Silver Curve

@stefanpenner

This comment has been minimized.

Show comment
Hide comment
@stefanpenner

stefanpenner Aug 5, 2014

Contributor

@Twinkletoes i will be content with master and branches (pull requests can be for the future)

This might be outdated, but may be of help: https://github.com/andypols/git-bamboo-plugin/tree/master

Contributor

stefanpenner commented Aug 5, 2014

@Twinkletoes i will be content with master and branches (pull requests can be for the future)

This might be outdated, but may be of help: https://github.com/andypols/git-bamboo-plugin/tree/master

@stefanpenner

This comment has been minimized.

Show comment
Hide comment
@stefanpenner

stefanpenner Aug 5, 2014

Contributor

@Twinkletoes sorry I combined CI with the Vagrant file. You can assume that is a separate issue.

but for reference: http://www.vagrantup.com/ TL;DR a quick configuration file to build-up a vm for development.

@dgtman maybe if you have some extra resources, assembling such a vagrant file for us would reduce the overhead in configuring and getting a windows environment setup.

Contributor

stefanpenner commented Aug 5, 2014

@Twinkletoes sorry I combined CI with the Vagrant file. You can assume that is a separate issue.

but for reference: http://www.vagrantup.com/ TL;DR a quick configuration file to build-up a vm for development.

@dgtman maybe if you have some extra resources, assembling such a vagrant file for us would reduce the overhead in configuring and getting a windows environment setup.

@BryanCrotaz

This comment has been minimized.

Show comment
Hide comment
@BryanCrotaz

BryanCrotaz Aug 5, 2014

We're on OnDemand so can't install plugins, so I'll just poll every 10 mins
for the version number and build if it changes.

On 5 August 2014 15:37, Stefan Penner notifications@github.com wrote:

@Twinkletoes https://github.com/Twinkletoes i will be content with
master and branches (pull requests can be for the future)

This might be outdated, but may be of help:
https://github.com/andypols/git-bamboo-plugin/tree/master


Reply to this email directly or view it on GitHub
#1558 (comment)
.

Bryan Crotaz
Managing Director
Silver Curve

BryanCrotaz commented Aug 5, 2014

We're on OnDemand so can't install plugins, so I'll just poll every 10 mins
for the version number and build if it changes.

On 5 August 2014 15:37, Stefan Penner notifications@github.com wrote:

@Twinkletoes https://github.com/Twinkletoes i will be content with
master and branches (pull requests can be for the future)

This might be outdated, but may be of help:
https://github.com/andypols/git-bamboo-plugin/tree/master


Reply to this email directly or view it on GitHub
#1558 (comment)
.

Bryan Crotaz
Managing Director
Silver Curve

@stefanpenner

This comment has been minimized.

Show comment
Hide comment
@stefanpenner

stefanpenner Aug 5, 2014

Contributor

@ccoenen I am planning to release v0.0.41 this evening (likely sometime after 8PM EST) If you have time today to try master on windows that would be a big help!

Contributor

stefanpenner commented Aug 5, 2014

@ccoenen I am planning to release v0.0.41 this evening (likely sometime after 8PM EST) If you have time today to try master on windows that would be a big help!

@ccoenen

This comment has been minimized.

Show comment
Hide comment
@ccoenen

ccoenen Aug 5, 2014

Contributor

@stefanpenner / @rwjblue i can confirm that the npm link instructions work on windows as well. Sorry, i missed that.

Contributor

ccoenen commented Aug 5, 2014

@stefanpenner / @rwjblue i can confirm that the npm link instructions work on windows as well. Sorry, i missed that.

@BryanCrotaz

This comment has been minimized.

Show comment
Hide comment
@BryanCrotaz

BryanCrotaz Aug 5, 2014

@stefanpenner I already have a clean windows environment VM on Amazon EC2,
so no need.

On 5 August 2014 15:40, Bryan Crotaz bryan.crotaz@silvercurve.co.uk wrote:

We're on OnDemand so can't install plugins, so I'll just poll every 10
mins for the version number and build if it changes.

On 5 August 2014 15:37, Stefan Penner notifications@github.com wrote:

@Twinkletoes https://github.com/Twinkletoes i will be content with
master and branches (pull requests can be for the future)

This might be outdated, but may be of help:
https://github.com/andypols/git-bamboo-plugin/tree/master


Reply to this email directly or view it on GitHub
#1558 (comment)
.

Bryan Crotaz
Managing Director
Silver Curve

Bryan Crotaz
Managing Director
Silver Curve

BryanCrotaz commented Aug 5, 2014

@stefanpenner I already have a clean windows environment VM on Amazon EC2,
so no need.

On 5 August 2014 15:40, Bryan Crotaz bryan.crotaz@silvercurve.co.uk wrote:

We're on OnDemand so can't install plugins, so I'll just poll every 10
mins for the version number and build if it changes.

On 5 August 2014 15:37, Stefan Penner notifications@github.com wrote:

@Twinkletoes https://github.com/Twinkletoes i will be content with
master and branches (pull requests can be for the future)

This might be outdated, but may be of help:
https://github.com/andypols/git-bamboo-plugin/tree/master


Reply to this email directly or view it on GitHub
#1558 (comment)
.

Bryan Crotaz
Managing Director
Silver Curve

Bryan Crotaz
Managing Director
Silver Curve

@stefanpenner

This comment has been minimized.

Show comment
Hide comment
@stefanpenner

stefanpenner Aug 5, 2014

Contributor

@Twinkletoes sounds good. Can you ensure it runs CI for each new SHA not just version? I would ideally like to catch issues before we release.

Contributor

stefanpenner commented Aug 5, 2014

@Twinkletoes sounds good. Can you ensure it runs CI for each new SHA not just version? I would ideally like to catch issues before we release.

@stefanpenner

This comment has been minimized.

Show comment
Hide comment
@stefanpenner

stefanpenner Aug 5, 2014

Contributor

BTW: thank you all for the enthusiasm and help. Without your help it would be near impossible to also support windows.

Contributor

stefanpenner commented Aug 5, 2014

BTW: thank you all for the enthusiasm and help. Without your help it would be near impossible to also support windows.

@BryanCrotaz

This comment has been minimized.

Show comment
Hide comment
@BryanCrotaz

BryanCrotaz Aug 5, 2014

@stefanpenner we're driven nuts by all the problems with ember-cli on
Windows, so glad to help - it's not just charity!!

Ember-cli is really really good but getting it running on Windows is
painful. Took me nearly 60 hours of solid work to get to a point where I
was productive. But the benefits are well worth it. So anything I can do to
improve that situation helps us here as well as everyone else.

On 5 August 2014 15:43, Stefan Penner notifications@github.com wrote:

BTW: thank you all for the enthusiasm and help. Without your help it would
be near impossible to also support windows.


Reply to this email directly or view it on GitHub
#1558 (comment)
.

Bryan Crotaz
Managing Director
Silver Curve

BryanCrotaz commented Aug 5, 2014

@stefanpenner we're driven nuts by all the problems with ember-cli on
Windows, so glad to help - it's not just charity!!

Ember-cli is really really good but getting it running on Windows is
painful. Took me nearly 60 hours of solid work to get to a point where I
was productive. But the benefits are well worth it. So anything I can do to
improve that situation helps us here as well as everyone else.

On 5 August 2014 15:43, Stefan Penner notifications@github.com wrote:

BTW: thank you all for the enthusiasm and help. Without your help it would
be near impossible to also support windows.


Reply to this email directly or view it on GitHub
#1558 (comment)
.

Bryan Crotaz
Managing Director
Silver Curve

@stefanpenner

This comment has been minimized.

Show comment
Hide comment
@stefanpenner

stefanpenner Aug 5, 2014

Contributor

@Twinkletoes I appreciate the help. I can assure you getting to this point on *nix has taking massive amounts of time as-well. Hopefully the time spent on windows will be dramatically less, but by polling resources and people-power we can get it to a good place soon.

I am also curious what some of the solutions you came to during you 60h of work.

Contributor

stefanpenner commented Aug 5, 2014

@Twinkletoes I appreciate the help. I can assure you getting to this point on *nix has taking massive amounts of time as-well. Hopefully the time spent on windows will be dramatically less, but by polling resources and people-power we can get it to a good place soon.

I am also curious what some of the solutions you came to during you 60h of work.

@kellyselden

This comment has been minimized.

Show comment
Hide comment
@kellyselden

kellyselden Aug 5, 2014

Member

I will update the Windows issues/workarounds in the docs when I come across them.
@stefanpenner I've done a fair amount of Vagrant work on Windows. Perhaps I can help with that.

Member

kellyselden commented Aug 5, 2014

I will update the Windows issues/workarounds in the docs when I come across them.
@stefanpenner I've done a fair amount of Vagrant work on Windows. Perhaps I can help with that.

@stefanpenner

This comment has been minimized.

Show comment
Hide comment
@stefanpenner

stefanpenner Aug 5, 2014

Contributor

@kellyselden that would be incredibly helpful

Contributor

stefanpenner commented Aug 5, 2014

@kellyselden that would be incredibly helpful

@stefanpenner

This comment has been minimized.

Show comment
Hide comment
@stefanpenner

stefanpenner Aug 5, 2014

Contributor

@Twinkletoes / @kellyselden if you are able to join us, several of us are having a conversation in the IRC channel (#ember-cli on freenode)

Contributor

stefanpenner commented Aug 5, 2014

@Twinkletoes / @kellyselden if you are able to join us, several of us are having a conversation in the IRC channel (#ember-cli on freenode)

@WMeldon

This comment has been minimized.

Show comment
Hide comment
@WMeldon

WMeldon Aug 5, 2014

Contributor

Just gonna leave this here
https://ci.appveyor.com/project/WMeldon/ember-cli

Sort of works, could have some potential.

Contributor

WMeldon commented Aug 5, 2014

Just gonna leave this here
https://ci.appveyor.com/project/WMeldon/ember-cli

Sort of works, could have some potential.

@stefanpenner

This comment has been minimized.

Show comment
Hide comment
@stefanpenner

stefanpenner Aug 5, 2014

Contributor

@WMeldon this seems good. What must we do to have this be part of our build?

@Twinkletoes thoughts?

Contributor

stefanpenner commented Aug 5, 2014

@WMeldon this seems good. What must we do to have this be part of our build?

@Twinkletoes thoughts?

@stefanpenner

This comment has been minimized.

Show comment
Hide comment
@stefanpenner

This comment has been minimized.

Show comment
Hide comment
@stefanpenner
Contributor

stefanpenner commented Aug 5, 2014

Build status

@stefanpenner

This comment has been minimized.

Show comment
Hide comment
@stefanpenner

stefanpenner Aug 5, 2014

Contributor

seems like windows CI task is now complete. We now need it to actually be green!

Contributor

stefanpenner commented Aug 5, 2014

seems like windows CI task is now complete. We now need it to actually be green!

@WMeldon

This comment has been minimized.

Show comment
Hide comment
@WMeldon

WMeldon Aug 5, 2014

Contributor

@stefanpenner WMeldon@3ffc4cd

That's the file I used. There may be some changes that need to occur and the mocha bug needs to be fixed.

Contributor

WMeldon commented Aug 5, 2014

@stefanpenner WMeldon@3ffc4cd

That's the file I used. There may be some changes that need to occur and the mocha bug needs to be fixed.

@BryanCrotaz

This comment has been minimized.

Show comment
Hide comment
@BryanCrotaz

BryanCrotaz Aug 5, 2014

@stefanpenner @WMeldon so no need for me to set up on my build server?

Is that build logging status to github at the end?

On 5 August 2014 16:49, Will Meldon notifications@github.com wrote:

@stefanpenner https://github.com/stefanpenner WMeldon/ember-cli@3ffc4cd
WMeldon@3ffc4cd

That's the file I used. There may be some changes that need to occur and
the mocha bug needs to be fixed.


Reply to this email directly or view it on GitHub
#1558 (comment)
.

Bryan Crotaz
Managing Director
Silver Curve

BryanCrotaz commented Aug 5, 2014

@stefanpenner @WMeldon so no need for me to set up on my build server?

Is that build logging status to github at the end?

On 5 August 2014 16:49, Will Meldon notifications@github.com wrote:

@stefanpenner https://github.com/stefanpenner WMeldon/ember-cli@3ffc4cd
WMeldon@3ffc4cd

That's the file I used. There may be some changes that need to occur and
the mocha bug needs to be fixed.


Reply to this email directly or view it on GitHub
#1558 (comment)
.

Bryan Crotaz
Managing Director
Silver Curve

@stefanpenner

This comment has been minimized.

Show comment
Hide comment
@stefanpenner

stefanpenner Aug 5, 2014

Contributor

@Twinkletoes it is, atleast on the README

Ya I think we don't need the CI server anymore, this seems to be great.

We could use help:

  1. getting the windows CI green
  2. improve the local development experience for *nix users when fixing windows issues (likely via Vagrant)
  3. anything else that makes windows users have a better time
Contributor

stefanpenner commented Aug 5, 2014

@Twinkletoes it is, atleast on the README

Ya I think we don't need the CI server anymore, this seems to be great.

We could use help:

  1. getting the windows CI green
  2. improve the local development experience for *nix users when fixing windows issues (likely via Vagrant)
  3. anything else that makes windows users have a better time
@BryanCrotaz

This comment has been minimized.

Show comment
Hide comment
@BryanCrotaz

BryanCrotaz Aug 5, 2014

ah - that's new - it wasn't reporting an hour ago when I was investigating

On 5 August 2014 17:02, Stefan Penner notifications@github.com wrote:

@Twinkletoes https://github.com/Twinkletoes it is, atleast on the README
https://github.com/stefanpenner/ember-cli/blob/master/README.md#ember-cli----windows


Reply to this email directly or view it on GitHub
#1558 (comment)
.

Bryan Crotaz
Managing Director
Silver Curve

BryanCrotaz commented Aug 5, 2014

ah - that's new - it wasn't reporting an hour ago when I was investigating

On 5 August 2014 17:02, Stefan Penner notifications@github.com wrote:

@Twinkletoes https://github.com/Twinkletoes it is, atleast on the README
https://github.com/stefanpenner/ember-cli/blob/master/README.md#ember-cli----windows


Reply to this email directly or view it on GitHub
#1558 (comment)
.

Bryan Crotaz
Managing Director
Silver Curve

@BryanCrotaz

This comment has been minimized.

Show comment
Hide comment
@BryanCrotaz

BryanCrotaz Aug 5, 2014

ok I'll help out with script writing

On 5 August 2014 17:04, Bryan Crotaz bryan.crotaz@silvercurve.co.uk wrote:

ah - that's new - it wasn't reporting an hour ago when I was investigating

On 5 August 2014 17:02, Stefan Penner notifications@github.com wrote:

@Twinkletoes https://github.com/Twinkletoes it is, atleast on the
README
https://github.com/stefanpenner/ember-cli/blob/master/README.md#ember-cli----windows


Reply to this email directly or view it on GitHub
#1558 (comment)
.

Bryan Crotaz
Managing Director
Silver Curve

Bryan Crotaz
Managing Director
Silver Curve

BryanCrotaz commented Aug 5, 2014

ok I'll help out with script writing

On 5 August 2014 17:04, Bryan Crotaz bryan.crotaz@silvercurve.co.uk wrote:

ah - that's new - it wasn't reporting an hour ago when I was investigating

On 5 August 2014 17:02, Stefan Penner notifications@github.com wrote:

@Twinkletoes https://github.com/Twinkletoes it is, atleast on the
README
https://github.com/stefanpenner/ember-cli/blob/master/README.md#ember-cli----windows


Reply to this email directly or view it on GitHub
#1558 (comment)
.

Bryan Crotaz
Managing Director
Silver Curve

Bryan Crotaz
Managing Director
Silver Curve

@david-duncan

This comment has been minimized.

Show comment
Hide comment
@david-duncan

david-duncan Aug 5, 2014

Our team has an issue we think is related to windows and broccolijs/broccoli#179

We noticed that tmp folder never clears. Ember server seems to continuously increase the size of the tmp folder until indexing on the drive comes to a halt.

david-duncan commented Aug 5, 2014

Our team has an issue we think is related to windows and broccolijs/broccoli#179

We noticed that tmp folder never clears. Ember server seems to continuously increase the size of the tmp folder until indexing on the drive comes to a halt.

@raytiley

This comment has been minimized.

Show comment
Hide comment
@raytiley

raytiley Aug 5, 2014

Member

@david-duncan I noticed that yesterday doing some stuff... my tmp folder was 13 GB or something. Haven't had time to dig in.

Member

raytiley commented Aug 5, 2014

@david-duncan I noticed that yesterday doing some stuff... my tmp folder was 13 GB or something. Haven't had time to dig in.

@stefanpenner

This comment has been minimized.

Show comment
Hide comment
@stefanpenner

stefanpenner Aug 14, 2014

Contributor

@Twinkletoes are you using git-bash or the regular cmd.exe (or something else) ?

Contributor

stefanpenner commented Aug 14, 2014

@Twinkletoes are you using git-bash or the regular cmd.exe (or something else) ?

@BryanCrotaz

This comment has been minimized.

Show comment
Hide comment
@BryanCrotaz

BryanCrotaz Aug 14, 2014

Using npm install ember-cli

We get 0.0.39 when we expected 0.0.40 and none if the broccoli plugins.

Also Jquery doesn't have a dist folder so we have to copy Jquery.js into a
new dist

Happens in mac and windows the same.

Bryan Crotaz
Silver Curve

On 14 Aug 2014, at 04:09, Stefan Penner notifications@github.com wrote:

@Twinkletoes https://github.com/Twinkletoes are you using git-bash or...?


Reply to this email directly or view it on GitHub
#1558 (comment)
.

BryanCrotaz commented Aug 14, 2014

Using npm install ember-cli

We get 0.0.39 when we expected 0.0.40 and none if the broccoli plugins.

Also Jquery doesn't have a dist folder so we have to copy Jquery.js into a
new dist

Happens in mac and windows the same.

Bryan Crotaz
Silver Curve

On 14 Aug 2014, at 04:09, Stefan Penner notifications@github.com wrote:

@Twinkletoes https://github.com/Twinkletoes are you using git-bash or...?


Reply to this email directly or view it on GitHub
#1558 (comment)
.

@stefanpenner

This comment has been minimized.

Show comment
Hide comment
@stefanpenner

stefanpenner Aug 14, 2014

Contributor

@Twinkletoes ah, this actually doesn't sound like a bug or problem directly with ember-cli rather an issue with npm/bower and your environment (potentially firewall).

Sounds to me like your installation is actually not succeeding. npm install and bower install are likely failing, this is quite commonly a problem if a corporate firewall is blocking ports they need.

Additionally please ensure your projects package.json includes the correct version of ember-cli.

in your project directory please try re-installing all the dependencies (if on windows please use the windows equivalent commands)

rm -rf node_modules
rm -rf vendor
npm cache clear
npm install
bower install
Contributor

stefanpenner commented Aug 14, 2014

@Twinkletoes ah, this actually doesn't sound like a bug or problem directly with ember-cli rather an issue with npm/bower and your environment (potentially firewall).

Sounds to me like your installation is actually not succeeding. npm install and bower install are likely failing, this is quite commonly a problem if a corporate firewall is blocking ports they need.

Additionally please ensure your projects package.json includes the correct version of ember-cli.

in your project directory please try re-installing all the dependencies (if on windows please use the windows equivalent commands)

rm -rf node_modules
rm -rf vendor
npm cache clear
npm install
bower install
@ccoenen

This comment has been minimized.

Show comment
Hide comment
@ccoenen

ccoenen Sep 1, 2014

Contributor

I have a pretty detailed bug-analysis of the remaining six failing tests. Here's my write-up.

https://gist.github.com/ccoenen/e8e7873de5614b9a657b

I'll try to convert them to pull requests. But especially the error 1) is a bit of a brain twister for me. I don't quite understand why that happens only for this instance of runCommand? It is used in many other cases as well.

Contributor

ccoenen commented Sep 1, 2014

I have a pretty detailed bug-analysis of the remaining six failing tests. Here's my write-up.

https://gist.github.com/ccoenen/e8e7873de5614b9a657b

I'll try to convert them to pull requests. But especially the error 1) is a bit of a brain twister for me. I don't quite understand why that happens only for this instance of runCommand? It is used in many other cases as well.

@raytiley

This comment has been minimized.

Show comment
Hide comment
@raytiley

raytiley Sep 2, 2014

Member

@ccoenen nice write up. I got around the first issue w/ this PR. #1682

It also has a hack to get around some issues I was having w/ the acceptance tests. Maybe that was fixed since I was working on this?

Member

raytiley commented Sep 2, 2014

@ccoenen nice write up. I got around the first issue w/ this PR. #1682

It also has a hack to get around some issues I was having w/ the acceptance tests. Maybe that was fixed since I was working on this?

@Dhaulagiri

This comment has been minimized.

Show comment
Hide comment
@Dhaulagiri

Dhaulagiri Sep 9, 2014

Contributor

Even on the latest version of ember-cli my /tmp directory does not clear on Windows

Contributor

Dhaulagiri commented Sep 9, 2014

Even on the latest version of ember-cli my /tmp directory does not clear on Windows

@vinz243

This comment has been minimized.

Show comment
Hide comment
@vinz243

vinz243 Sep 14, 2014

I am not an expert but I can help all the same by testing or whatever :). I am using Windows 7 but I have very bad performance (60" compile time). I disabled avast and add the rule to windows defender it doesn't help :-. The files are not on C:/ so they are not indexed by windows search. In the middle I'll consider dual boot.

vinz243 commented Sep 14, 2014

I am not an expert but I can help all the same by testing or whatever :). I am using Windows 7 but I have very bad performance (60" compile time). I disabled avast and add the rule to windows defender it doesn't help :-. The files are not on C:/ so they are not indexed by windows search. In the middle I'll consider dual boot.

@ccoenen

This comment has been minimized.

Show comment
Hide comment
@ccoenen

ccoenen Sep 15, 2014

Contributor

60 seconds? That sounds really way to long. How large is the project? I get ~4-6 seconds rebuilds on a new project, and still <10 seconds for a moderately complex project. (Win 8.1, SSD, exceptions for defender AND search indexer)

Contributor

ccoenen commented Sep 15, 2014

60 seconds? That sounds really way to long. How large is the project? I get ~4-6 seconds rebuilds on a new project, and still <10 seconds for a moderately complex project. (Win 8.1, SSD, exceptions for defender AND search indexer)

@stefanpenner

This comment has been minimized.

Show comment
Hide comment
@stefanpenner

stefanpenner Sep 15, 2014

Contributor

@ccoenen i've also seen some poorly behaving filters cause massive problems. Also people running on encrypted drives will run into problems. (If the tmp dir is also being encrypted).

Contributor

stefanpenner commented Sep 15, 2014

@ccoenen i've also seen some poorly behaving filters cause massive problems. Also people running on encrypted drives will run into problems. (If the tmp dir is also being encrypted).

@vinz243

This comment has been minimized.

Show comment
Hide comment
@vinz243

vinz243 Sep 15, 2014

Well my project is quite small. I started it a few time ago and since the dev was tedious because of the compile time, I scarcely wrote more than 50 lines of code 👅

These are the specs and programs running and other things as well:

  • AMD Athlon 5000+ X64 @2.3GHz
  • DDR2 Kingston 4 Go
  • The project is located on H:/
  • IDE: Atom Editor
  • Command prompt: CmdEr
  • Browser Firefox
  • Background programs:
    • Avast
    • Soluto
    • Rainmeter

I had already some issues using editor (files locked by atom whioch I could not remove whereas they were not open). Perhaps I should try without any IDE?

vinz243 commented Sep 15, 2014

Well my project is quite small. I started it a few time ago and since the dev was tedious because of the compile time, I scarcely wrote more than 50 lines of code 👅

These are the specs and programs running and other things as well:

  • AMD Athlon 5000+ X64 @2.3GHz
  • DDR2 Kingston 4 Go
  • The project is located on H:/
  • IDE: Atom Editor
  • Command prompt: CmdEr
  • Browser Firefox
  • Background programs:
    • Avast
    • Soluto
    • Rainmeter

I had already some issues using editor (files locked by atom whioch I could not remove whereas they were not open). Perhaps I should try without any IDE?

@inDream

This comment has been minimized.

Show comment
Hide comment
@inDream

inDream Sep 17, 2014

Contributor
  • Windows 8.1
  • node.js 0.10.31
  • ember-cli 0.0.44-master-acb04105c6
  • Intel i7-4702MQ @2.2GHz
  • 16 GB DDR3
  • Hitachi Travelstar 5K1000 750GB
  • Avast (tried turn off but no differences)
  • Turned off Windows Defender & folder not indexed

Brocfile.js, bower.json, package.json and log from ls -R -l in /app and /tmp after ember s: https://gist.github.com/inDream/1d7f4d9cac6c5ce4b1af

/app + /bower_components = 1052 files & 189 folders = 19MB
/tmp = 7,846 files & 1630 folders = 173MB

Is it necessary to copy the files so many times? I think this is the reason of low performance.

Build successful with 18463ms.

  Slowest Trees                   | Total
-------------------------------+----------------
TreeMerger (appAndDependencies)   | 3401ms
TreeMerger (ExternalTree)         | 2793ms
TreeMerger (stylesAndVendor)      | 2569ms
CustomStaticCompiler              | 2250ms
Contributor

inDream commented Sep 17, 2014

  • Windows 8.1
  • node.js 0.10.31
  • ember-cli 0.0.44-master-acb04105c6
  • Intel i7-4702MQ @2.2GHz
  • 16 GB DDR3
  • Hitachi Travelstar 5K1000 750GB
  • Avast (tried turn off but no differences)
  • Turned off Windows Defender & folder not indexed

Brocfile.js, bower.json, package.json and log from ls -R -l in /app and /tmp after ember s: https://gist.github.com/inDream/1d7f4d9cac6c5ce4b1af

/app + /bower_components = 1052 files & 189 folders = 19MB
/tmp = 7,846 files & 1630 folders = 173MB

Is it necessary to copy the files so many times? I think this is the reason of low performance.

Build successful with 18463ms.

  Slowest Trees                   | Total
-------------------------------+----------------
TreeMerger (appAndDependencies)   | 3401ms
TreeMerger (ExternalTree)         | 2793ms
TreeMerger (stylesAndVendor)      | 2569ms
CustomStaticCompiler              | 2250ms
@stefanpenner

This comment has been minimized.

Show comment
Hide comment
@stefanpenner

stefanpenner Sep 18, 2014

Contributor

@inDream copying concern please read -> broccolijs/broccoli#179 Hopefully soon *nix systems will once again not copy, after which windows will likely get the same love.

Contributor

stefanpenner commented Sep 18, 2014

@inDream copying concern please read -> broccolijs/broccoli#179 Hopefully soon *nix systems will once again not copy, after which windows will likely get the same love.

@ultimatemonty

This comment has been minimized.

Show comment
Hide comment
@ultimatemonty

ultimatemonty Oct 8, 2014

@stefanpenner @rwjblue I'm in the process of converting a fairly large and complex app from a bastardized version of EAK to CLI. I don't have the margins to dig into development contributions but I'm certainly willing to run the latest and greatest CLI in my Windows development environment and provide any performance/debug information you might find useful. I'm currently using Win 7 Enterprise x64 on a Core i7-2620M, 8GB RAM, and 500GB HDD. My build times average around 10-15 seconds and this is with only a few templates, routes, controllers, models, etc... converted from my larger application. I have a feeling part of my issue is using Broccoli properly (merging trees instead of individual files, etc...). I can provide more information as needed.

ultimatemonty commented Oct 8, 2014

@stefanpenner @rwjblue I'm in the process of converting a fairly large and complex app from a bastardized version of EAK to CLI. I don't have the margins to dig into development contributions but I'm certainly willing to run the latest and greatest CLI in my Windows development environment and provide any performance/debug information you might find useful. I'm currently using Win 7 Enterprise x64 on a Core i7-2620M, 8GB RAM, and 500GB HDD. My build times average around 10-15 seconds and this is with only a few templates, routes, controllers, models, etc... converted from my larger application. I have a feeling part of my issue is using Broccoli properly (merging trees instead of individual files, etc...). I can provide more information as needed.

@stefanpenner

This comment has been minimized.

Show comment
Hide comment
@stefanpenner

stefanpenner Oct 8, 2014

Contributor

@ulisesrmzroche broccolijs/node-symlink-or-copy#1 is likely were we will make windows fast. (as that aims to bring it into alignment with how we get fast unix times)

Contributor

stefanpenner commented Oct 8, 2014

@ulisesrmzroche broccolijs/node-symlink-or-copy#1 is likely were we will make windows fast. (as that aims to bring it into alignment with how we get fast unix times)

@duizendnegen

This comment has been minimized.

Show comment
Hide comment
@duizendnegen

duizendnegen Oct 31, 2014

Hi, I'm interested in getting more involved with helping on the Ember-CLI Windows side.

In the mean time, a bit hacky, if you are an admin / know you have symlink permissions & are desperate to get Windows speed improvement, you can use stefanpenner/node-symlink-or-copy#1
You could use "ember-cli": "Kyusuke/ember-cli#0b5be796441824a5964adcbdef6b55b2c6fba62b", in your package.json (but beware you are at our mercy for merging Ember CLI often enough)

duizendnegen commented Oct 31, 2014

Hi, I'm interested in getting more involved with helping on the Ember-CLI Windows side.

In the mean time, a bit hacky, if you are an admin / know you have symlink permissions & are desperate to get Windows speed improvement, you can use stefanpenner/node-symlink-or-copy#1
You could use "ember-cli": "Kyusuke/ember-cli#0b5be796441824a5964adcbdef6b55b2c6fba62b", in your package.json (but beware you are at our mercy for merging Ember CLI often enough)

@stefanpenner

This comment has been minimized.

Show comment
Hide comment
@stefanpenner

stefanpenner Oct 31, 2014

Contributor

@duizendnegen awesome, We can use all the help we can get.

Contributor

stefanpenner commented Oct 31, 2014

@duizendnegen awesome, We can use all the help we can get.

@stefanpenner stefanpenner added this to the v1.0.0 milestone Nov 25, 2014

@stefanpenner

This comment has been minimized.

Show comment
Hide comment
@stefanpenner

stefanpenner Nov 27, 2014

Contributor

Hey guys, I've been swamped or I would have been trying to do more windows support. As you all likely know this is mostly a evenings/weekends hobby project for myself so time is quite limited.

Luckily, one of our clients is sponsoring 3 days of 100% windows + ember-cli love next week. I hope to make a big dent in the above issues. Performance is the first priority.

We have made great progress on windows performance, and I hope to have the work in mainline by the end of next week.

The symlinking branch of node-symlink-or-copy is showing nearly an order of magnitude improvement.

examples:

Windows 8.1 running in Parallels on a Macbook Pro Early 2013 with an ssd drive.

================= BEFORE ========================

Build successful - 50745ms.

Slowest Trees                  | Total
-------------------------------+----------------
TreeMerger (appAndDependencies) | 7512ms
TreeMerger (stylesAndVendor)   | 6309ms
TreeMerger (ExternalTree)      | 6234ms
CustomStaticCompiler           | 5940ms
JSHint - App                   | 2638ms
ES3SafeFilter                  | 2594ms

file changed router.js

Build successful - 43748ms.

Slowest Trees                  | Total
-------------------------------+----------------
TreeMerger (appAndDependencies) | 9213ms
TreeMerger (stylesAndVendor)   | 7095ms
TreeMerger (ExternalTree)      | 6691ms
CustomStaticCompiler           | 4543ms



================= AFTER ========================

Build successful - 14160ms.

Slowest Trees                  | Total
-------------------------------+----------------
ES3SafeFilter                  | 2726ms
JSHint - App                   | 2336ms
AutoprefixerFilter             | 1797ms
LessCompiler                   | 1772ms
ES6Concatenator                | 1289ms
TemplateCompiler               | 812ms

file changed router.js

Build successful - 5710ms.

Slowest Trees                  | Total
-------------------------------+----------------
Funnel                         | 1044ms
ES3SafeFilter                  | 736ms
AutoprefixerFilter             | 647ms
JSHint - App                   | 628ms
TemplateCompiler               | 346ms
StaticCompiler                 | 331ms

and

Windows 7 on a Dell laptop, don't know the specs. No ssd drive.

================= BEFORE ========================

Build successful - 106919ms.

Slowest Trees                  | Total
-------------------------------+----------------
TreeMerger (appAndDependencies) | 21267ms
TreeMerger (ExternalTree)      | 14910ms
CustomStaticCompiler           | 13670ms
Funnel                         | 12932ms
TreeMerger (stylesAndVendor)   | 7136ms

file changed router.js

Build successful - 60417ms.

Slowest Trees                  | Total
-------------------------------+----------------
TreeMerger (stylesAndVendor)   | 10915ms
TreeMerger (ExternalTree)      | 7072ms
TreeMerger (appAndDependencies) | 6164ms
ES3SafeFilter                  | 5208ms
CustomStaticCompiler           | 5001ms


================= AFTER ========================

Build successful - 10851ms.

Slowest Trees                  | Total
-------------------------------+----------------
ES3SafeFilter                  | 3226ms
JSHint - App                   | 1569ms
LessCompiler                   | 1359ms
AutoprefixerFilter             | 1007ms
ES6Concatenator                | 949ms

file changed router.js

Build successful - 6500ms.

Slowest Trees                  | Total
-------------------------------+----------------
StaticCompiler                 | 1226ms
ES3SafeFilter                  | 800ms
JSHint - App                   | 657ms
TreeMerger                     | 644ms
Funnel                         | 587ms
AutoprefixerFilter             | 427ms

source: broccolijs/node-symlink-or-copy#1 (comment)

Contributor

stefanpenner commented Nov 27, 2014

Hey guys, I've been swamped or I would have been trying to do more windows support. As you all likely know this is mostly a evenings/weekends hobby project for myself so time is quite limited.

Luckily, one of our clients is sponsoring 3 days of 100% windows + ember-cli love next week. I hope to make a big dent in the above issues. Performance is the first priority.

We have made great progress on windows performance, and I hope to have the work in mainline by the end of next week.

The symlinking branch of node-symlink-or-copy is showing nearly an order of magnitude improvement.

examples:

Windows 8.1 running in Parallels on a Macbook Pro Early 2013 with an ssd drive.

================= BEFORE ========================

Build successful - 50745ms.

Slowest Trees                  | Total
-------------------------------+----------------
TreeMerger (appAndDependencies) | 7512ms
TreeMerger (stylesAndVendor)   | 6309ms
TreeMerger (ExternalTree)      | 6234ms
CustomStaticCompiler           | 5940ms
JSHint - App                   | 2638ms
ES3SafeFilter                  | 2594ms

file changed router.js

Build successful - 43748ms.

Slowest Trees                  | Total
-------------------------------+----------------
TreeMerger (appAndDependencies) | 9213ms
TreeMerger (stylesAndVendor)   | 7095ms
TreeMerger (ExternalTree)      | 6691ms
CustomStaticCompiler           | 4543ms



================= AFTER ========================

Build successful - 14160ms.

Slowest Trees                  | Total
-------------------------------+----------------
ES3SafeFilter                  | 2726ms
JSHint - App                   | 2336ms
AutoprefixerFilter             | 1797ms
LessCompiler                   | 1772ms
ES6Concatenator                | 1289ms
TemplateCompiler               | 812ms

file changed router.js

Build successful - 5710ms.

Slowest Trees                  | Total
-------------------------------+----------------
Funnel                         | 1044ms
ES3SafeFilter                  | 736ms
AutoprefixerFilter             | 647ms
JSHint - App                   | 628ms
TemplateCompiler               | 346ms
StaticCompiler                 | 331ms

and

Windows 7 on a Dell laptop, don't know the specs. No ssd drive.

================= BEFORE ========================

Build successful - 106919ms.

Slowest Trees                  | Total
-------------------------------+----------------
TreeMerger (appAndDependencies) | 21267ms
TreeMerger (ExternalTree)      | 14910ms
CustomStaticCompiler           | 13670ms
Funnel                         | 12932ms
TreeMerger (stylesAndVendor)   | 7136ms

file changed router.js

Build successful - 60417ms.

Slowest Trees                  | Total
-------------------------------+----------------
TreeMerger (stylesAndVendor)   | 10915ms
TreeMerger (ExternalTree)      | 7072ms
TreeMerger (appAndDependencies) | 6164ms
ES3SafeFilter                  | 5208ms
CustomStaticCompiler           | 5001ms


================= AFTER ========================

Build successful - 10851ms.

Slowest Trees                  | Total
-------------------------------+----------------
ES3SafeFilter                  | 3226ms
JSHint - App                   | 1569ms
LessCompiler                   | 1359ms
AutoprefixerFilter             | 1007ms
ES6Concatenator                | 949ms

file changed router.js

Build successful - 6500ms.

Slowest Trees                  | Total
-------------------------------+----------------
StaticCompiler                 | 1226ms
ES3SafeFilter                  | 800ms
JSHint - App                   | 657ms
TreeMerger                     | 644ms
Funnel                         | 587ms
AutoprefixerFilter             | 427ms

source: broccolijs/node-symlink-or-copy#1 (comment)

@kellyselden

This comment has been minimized.

Show comment
Hide comment
@kellyselden

kellyselden Nov 27, 2014

Member

@stefanpenner awesome. Let me know if I can help out, perhaps some more vagrant work or environment testing. I'm on Windows 7.

Member

kellyselden commented Nov 27, 2014

@stefanpenner awesome. Let me know if I can help out, perhaps some more vagrant work or environment testing. I'm on Windows 7.

@stefanpenner

This comment has been minimized.

Show comment
Hide comment
@stefanpenner

stefanpenner Dec 5, 2014

Contributor

Windows CI is green, and symlinking with much better performance works if you follow http://www.ember-cli.com/#symlinks-on-windows

Contributor

stefanpenner commented Dec 5, 2014

Windows CI is green, and symlinking with much better performance works if you follow http://www.ember-cli.com/#symlinks-on-windows

@bpcrao

This comment has been minimized.

Show comment
Hide comment
@bpcrao

bpcrao Apr 22, 2015

did not imrpove much for me with symlinks it takes around 60 seconds for a build

bpcrao commented Apr 22, 2015

did not imrpove much for me with symlinks it takes around 60 seconds for a build

@stefanpenner

This comment has been minimized.

Show comment
Hide comment
@stefanpenner

stefanpenner Apr 22, 2015

Contributor

did not imrpove much for me with symlinks it takes around 60 seconds for a build

build or rebuild? these are different beasts.

Contributor

stefanpenner commented Apr 22, 2015

did not imrpove much for me with symlinks it takes around 60 seconds for a build

build or rebuild? these are different beasts.

@bpcrao

This comment has been minimized.

Show comment
Hide comment
@bpcrao

bpcrao Apr 23, 2015

build is 60 seconds rebuild is 30 seconds.

bpcrao commented Apr 23, 2015

build is 60 seconds rebuild is 30 seconds.

@duizendnegen

This comment has been minimized.

Show comment
Hide comment
@duizendnegen

duizendnegen Apr 23, 2015

Improved for me initially (to build/rebuild around 4s) but back at 40s/25s now on Win7

On Thu, Apr 23, 2015 at 3:45 AM, Purna Boyapati notifications@github.com
wrote:

build is 60 seconds rebuild is 30 seconds.

Reply to this email directly or view it on GitHub:
#1558 (comment)

duizendnegen commented Apr 23, 2015

Improved for me initially (to build/rebuild around 4s) but back at 40s/25s now on Win7

On Thu, Apr 23, 2015 at 3:45 AM, Purna Boyapati notifications@github.com
wrote:

build is 60 seconds rebuild is 30 seconds.

Reply to this email directly or view it on GitHub:
#1558 (comment)

@bpcrao

This comment has been minimized.

Show comment
Hide comment
@bpcrao

bpcrao Apr 23, 2015

@duizendnegen is your tmp folder empty when you do a build?

bpcrao commented Apr 23, 2015

@duizendnegen is your tmp folder empty when you do a build?

@BryanCrotaz

This comment has been minimized.

Show comment
Hide comment
@BryanCrotaz

BryanCrotaz Apr 23, 2015

I get a big difference in speed when I run the command prompt as
administrator. I think this allows broccoli to use symlinks.

Bryan

BryanCrotaz commented Apr 23, 2015

I get a big difference in speed when I run the command prompt as
administrator. I think this allows broccoli to use symlinks.

Bryan

@bpcrao

This comment has been minimized.

Show comment
Hide comment
@bpcrao

bpcrao Apr 23, 2015

@BryanCrotaz
Yes, with symlinks there is improvement
despite that build takes 60 sec, of that babel takes around 20 seconds

bpcrao commented Apr 23, 2015

@BryanCrotaz
Yes, with symlinks there is improvement
despite that build takes 60 sec, of that babel takes around 20 seconds

@joeyespo

This comment has been minimized.

Show comment
Hide comment
@joeyespo

joeyespo May 10, 2015

Contributor

My experience is the same as @bpcrao. ~60 seconds today (although better than before!), with Babel taking 20s of that. Running in Administrator mode doesn't help.

Contributor

joeyespo commented May 10, 2015

My experience is the same as @bpcrao. ~60 seconds today (although better than before!), with Babel taking 20s of that. Running in Administrator mode doesn't help.

@neilyoung

This comment has been minimized.

Show comment
Hide comment
@neilyoung

neilyoung Dec 18, 2015

The most annoying issue with ember-cli/broccoli on windows is, that due to strange dependency handling of brocooli (?) there are extremely long paths. You cannot even delete such a directory w/o being warned to have exceeded the max-path. I will stop messing with ember on windows

neilyoung commented Dec 18, 2015

The most annoying issue with ember-cli/broccoli on windows is, that due to strange dependency handling of brocooli (?) there are extremely long paths. You cannot even delete such a directory w/o being warned to have exceeded the max-path. I will stop messing with ember on windows

@stefanpenner

This comment has been minimized.

Show comment
Hide comment
@stefanpenner

stefanpenner Dec 18, 2015

Contributor

that due to strange dependency handling of brocooli

this would be npm, upgrading to npm version 3, produces much more flattened dependency structure.

you cannot even delete such a directory w/o being warned to have exceeded the max-path.

Yes, this is unfortunate. Surprisingly windows actually does support this, but various tools (python) and the windows file browser do not. I have no idea why they do not, but they don't...

One technique is using the node_module rimraf which uses the correct windows api, and works correctly.

npm install -g rimraf
rimraf large/tree/to/delete

It is a pretty big bummer, but we have been working with Microsoft (who are users of ember-cli) to continue to improve the experience.

cc @felixrieseberg

Contributor

stefanpenner commented Dec 18, 2015

that due to strange dependency handling of brocooli

this would be npm, upgrading to npm version 3, produces much more flattened dependency structure.

you cannot even delete such a directory w/o being warned to have exceeded the max-path.

Yes, this is unfortunate. Surprisingly windows actually does support this, but various tools (python) and the windows file browser do not. I have no idea why they do not, but they don't...

One technique is using the node_module rimraf which uses the correct windows api, and works correctly.

npm install -g rimraf
rimraf large/tree/to/delete

It is a pretty big bummer, but we have been working with Microsoft (who are users of ember-cli) to continue to improve the experience.

cc @felixrieseberg

@ccoenen

This comment has been minimized.

Show comment
Hide comment
@ccoenen

ccoenen Dec 18, 2015

Contributor

I can also recommend cmder as terminal emulator (download "full"). This will still be the regular cmd.exe shell, but you'll also have a nice round of unixy tools coming along with it. This includes rm, the unix command for deleting files. rm -rf temp works for me pretty well on windows.

Contributor

ccoenen commented Dec 18, 2015

I can also recommend cmder as terminal emulator (download "full"). This will still be the regular cmd.exe shell, but you'll also have a nice round of unixy tools coming along with it. This includes rm, the unix command for deleting files. rm -rf temp works for me pretty well on windows.

@stefanpenner

This comment has been minimized.

Show comment
Hide comment
@stefanpenner

stefanpenner Dec 18, 2015

Contributor

@ccoenen awesome, thanks for the tip.

Contributor

stefanpenner commented Dec 18, 2015

@ccoenen awesome, thanks for the tip.

@neilyoung

This comment has been minimized.

Show comment
Hide comment
@neilyoung

neilyoung Dec 18, 2015

@stefanpenner @ccoenen Thanks to both of you for your valuable hints. Will give both a try. I'm making a good progress with ember cli and Visual Studio Code on a Mac. Just wanted to return to the native environment for .net :)

neilyoung commented Dec 18, 2015

@stefanpenner @ccoenen Thanks to both of you for your valuable hints. Will give both a try. I'm making a good progress with ember cli and Visual Studio Code on a Mac. Just wanted to return to the native environment for .net :)

@kellyselden

This comment has been minimized.

Show comment
Hide comment
@kellyselden

kellyselden Dec 18, 2015

Member

Little tip for my fellow Windows users. If you install Git for Windows manually or via Chocolatey (cinst git.install), you can add the folder C:\Program Files\Git\usr\bin to your PATH, then get a plethora of unix tools, including rm, at your disposal.

Member

kellyselden commented Dec 18, 2015

Little tip for my fellow Windows users. If you install Git for Windows manually or via Chocolatey (cinst git.install), you can add the folder C:\Program Files\Git\usr\bin to your PATH, then get a plethora of unix tools, including rm, at your disposal.

@felixrieseberg

This comment has been minimized.

Show comment
Hide comment
@felixrieseberg

felixrieseberg Dec 21, 2015

Contributor

And, since npm@3 is putting a whole bunch of Windows goodness in, I'd stick pretty close to the latest npm versions. We wrote a small tool, helping you do upgrade 🚀

Contributor

felixrieseberg commented Dec 21, 2015

And, since npm@3 is putting a whole bunch of Windows goodness in, I'd stick pretty close to the latest npm versions. We wrote a small tool, helping you do upgrade 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment