New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Investigate] EOL in concat separator #6300

Closed
stefanpenner opened this Issue Sep 26, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@stefanpenner
Contributor

stefanpenner commented Sep 26, 2016

as per: #6081 (review)
it is strange that we use EOL not '\n' for builds: https://github.com/ember-cli/ember-cli/blob/master/lib/broccoli/ember-app.js#L1272

I believe in a perfect world, builds from win and builds from *nix produce the same outputs.

So open questions:

  • is there a reason why we did this?
  • is there any reason for us not to change it to \n in all cases.

@homu homu closed this in 1302053 Sep 27, 2016

homu added a commit that referenced this issue Sep 27, 2016

Auto merge of #6301 - ember-cli:consistent-concat-eol, r=Turbo87
[Fixes #6300] consistent concat, regardless of system EOL

@Turbo87 r?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment