New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change `EmberApp#tests` visibility to public #6656

Open
Turbo87 opened this Issue Jan 9, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@Turbo87
Copy link
Member

Turbo87 commented Jan 9, 2017

The tests property of EmberApp instances is currently not documented properly and should IMHO be a public property.

ember-cli-chai is one example of an addon that uses this flag already.

/cc @stefanpenner @rwjblue @nathanhammond

@rwjblue

This comment has been minimized.

Copy link
Contributor

rwjblue commented Jan 9, 2017

I agree whole heartedly that we should expose what this flag means, but would generally prefer to give it a better name (and deprecate this one) before officially making it public. I'm thinking of something like app.includesTests, app.hasTests, etc...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment