Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate --pod component broken in 3.13.1 #8864

Closed
lfrost opened this issue Sep 29, 2019 · 3 comments
Closed

generate --pod component broken in 3.13.1 #8864

lfrost opened this issue Sep 29, 2019 · 3 comments
Labels

Comments

@lfrost
Copy link

@lfrost lfrost commented Sep 29, 2019

When generating a component pod with ember-cli 3.13.1, the component JavaScript contains only "export default". When generating a component that is not in a pod, the JavaScript looks complete.


Output from ember version --verbose && npm --version && yarn --version:

$ ember version --verbose && npm --version && yarn --version
ember-cli: 3.13.1
http_parser: 2.8.0
node: 10.16.3
v8: 6.8.275.32-node.54
uv: 1.28.0
zlib: 1.2.11
brotli: 1.0.7
ares: 1.15.0
modules: 64
nghttp2: 1.39.2
napi: 4
openssl: 1.1.1c
icu: 64.2
unicode: 12.1
cldr: 35.1
tz: 2019a
os: linux x64
6.9.0
1.19.0
$ ember new --yarn test-components
installing app
Ember CLI v3.13.1

✨  Creating a new Ember app in ~/git/test-components:
  create .editorconfig
  create .ember-cli
  create .eslintignore
  create .eslintrc.js
  create .template-lintrc.js
  create .travis.yml
  create .watchmanconfig
  create README.md
  create app/app.js
  create app/components/.gitkeep
  create app/controllers/.gitkeep
  create app/helpers/.gitkeep
  create app/index.html
  create app/models/.gitkeep
  create app/resolver.js
  create app/router.js
  create app/routes/.gitkeep
  create app/styles/app.css
  create app/templates/application.hbs
  create app/templates/components/.gitkeep
  create config/environment.js
  create config/optional-features.json
  create config/targets.js
  create ember-cli-build.js
  create .gitignore
  create package.json
  create public/robots.txt
  create testem.js
  create tests/helpers/.gitkeep
  create tests/index.html
  create tests/integration/.gitkeep
  create tests/test-helper.js
  create tests/unit/.gitkeep
  create vendor/.gitkeep

🚧  Installing packages... This might take a couple of minutes.
Yarn: Installed dependencies

🎥  Initializing git repository.
Git: successfully initialized.

🎉  Successfully created project test-components.
👉   We suggest you that you get started by typing:

  $ cd test-components
  $ yarn start

Happy coding!
$ cd test-components
test-components$ ember generate --pod component some-pod
installing component
  create app/components/some-pod/component.js
  create app/components/some-pod/template.hbs
installing component-test
  create tests/integration/components/some-pod/component-test.js
lfrost@sinclair:~/git/test-components$ cat app/components/some-pod/component.js


export default 
test-components$ ember generate component not-pod
installing component
  create app/components/not-pod.js
  create app/templates/components/not-pod.hbs
installing component-test
  create tests/integration/components/not-pod-test.js
lfrost@sinclair:~/git/test-components$ cat app/components/not-pod.js
import Component from '@ember/component';

export default Component.extend({
});
@rwjblue

This comment has been minimized.

Copy link
Member

@rwjblue rwjblue commented Sep 30, 2019

Eeck, that does indeed seem completely wrong. Thank you for reporting!

@rwjblue

This comment has been minimized.

Copy link
Member

@rwjblue rwjblue commented Sep 30, 2019

The component blueprint is actually provided by ember-source, so we'll have to fix over there (would you mind migrating this issue to github.com/emberjs/ember.js?)...

@lfrost

This comment has been minimized.

Copy link
Author

@lfrost lfrost commented Sep 30, 2019

The component blueprint is actually provided by ember-source, so we'll have to fix over there (would you mind migrating this issue to github.com/emberjs/ember.js?)...

Done. Issue 18442.

@lfrost lfrost closed this Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.