-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Move to pnpm #10382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to pnpm #10382
Conversation
Thanks for doing this! Working with ember-cli is going to be so much better now! |
tests/helpers/acceptance.js
Outdated
process.chdir(runFixture); | ||
|
||
let pnpm = new CommandGenerator('npm'); | ||
pnpm.invoke('install'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--prefer-offline
for speed?
yarn.lock
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good riddance 🎉
@@ -15,6 +15,7 @@ let cleanupRun = acceptance.cleanupRun; | |||
|
|||
const { expect } = require('chai'); | |||
const { dir, file } = require('chai-files'); | |||
const linkFixtureDependnecy = require('../helpers/link-fixture-dependnecy'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const linkFixtureDependnecy = require('../helpers/link-fixture-dependnecy'); | |
const linkFixtureDependency = require('../helpers/link-fixture-dependency'); |
Small typo.
Comment from mansona: this doesn't actually solve the immediate problem he was trying to solve, around the test suite's package caching.
I'm hitting some issues with #10370 and I'm pretty sure it's because of the internal package cache for tests.
This PR is just to test how hard it might be to move to pnpm so we can remove our custom cache 👍