Conversation
NullVoxPopuli
previously approved these changes
Sep 19, 2023
Contributor
|
Thanks for doing this! Working with ember-cli is going to be so much better now! |
| process.chdir(runFixture); | ||
|
|
||
| let pnpm = new CommandGenerator('npm'); | ||
| pnpm.invoke('install'); |
Contributor
There was a problem hiding this comment.
--prefer-offline for speed?
bertdeblock
reviewed
Sep 19, 2023
|
|
||
| const { expect } = require('chai'); | ||
| const { dir, file } = require('chai-files'); | ||
| const linkFixtureDependnecy = require('../helpers/link-fixture-dependnecy'); |
Member
There was a problem hiding this comment.
Suggested change
| const linkFixtureDependnecy = require('../helpers/link-fixture-dependnecy'); | |
| const linkFixtureDependency = require('../helpers/link-fixture-dependency'); |
Small typo.
ef4
dismissed
NullVoxPopuli’s stale review
September 26, 2023 15:09
Comment from mansona: this doesn't actually solve the immediate problem he was trying to solve, around the test suite's package caching.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm hitting some issues with #10370 and I'm pretty sure it's because of the internal package cache for tests.
This PR is just to test how hard it might be to move to pnpm so we can remove our custom cache 👍