Skip to content

Move to pnpm #10382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Move to pnpm #10382

wants to merge 3 commits into from

Conversation

mansona
Copy link
Member

@mansona mansona commented Sep 19, 2023

I'm hitting some issues with #10370 and I'm pretty sure it's because of the internal package cache for tests.

This PR is just to test how hard it might be to move to pnpm so we can remove our custom cache 👍

NullVoxPopuli
NullVoxPopuli previously approved these changes Sep 19, 2023
@NullVoxPopuli
Copy link
Contributor

Thanks for doing this! Working with ember-cli is going to be so much better now!

process.chdir(runFixture);

let pnpm = new CommandGenerator('npm');
pnpm.invoke('install');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--prefer-offline for speed?

yarn.lock Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good riddance 🎉

@@ -15,6 +15,7 @@ let cleanupRun = acceptance.cleanupRun;

const { expect } = require('chai');
const { dir, file } = require('chai-files');
const linkFixtureDependnecy = require('../helpers/link-fixture-dependnecy');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const linkFixtureDependnecy = require('../helpers/link-fixture-dependnecy');
const linkFixtureDependency = require('../helpers/link-fixture-dependency');

Small typo.

@ef4 ef4 dismissed NullVoxPopuli’s stale review September 26, 2023 15:09

Comment from mansona: this doesn't actually solve the immediate problem he was trying to solve, around the test suite's package caching.

@ef4 ef4 closed this Sep 26, 2023
@bertdeblock bertdeblock deleted the pnpm branch November 5, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants