Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding howto disable win defender and win search index to gh-pages #1302

Merged
merged 1 commit into from Jul 24, 2014

Conversation

@ccoenen
Copy link
Contributor

commented Jul 7, 2014

As requested in #1294, i added the windows tips to the gh-pages branch.

Right now, the images don't load correctly. If anyone has an idea on how to fix that, i'd gladly take any help i can get.

@ccoenen ccoenen changed the title disable win defender and win search index adding howto disable win defender and win search index to gh-pages Jul 10, 2014

@ccoenen

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2014

if anyone has english screenshots handy, that would probably be better.

@jdjkelly

This comment has been minimized.

Copy link
Contributor

commented Jul 20, 2014

Seems like we're merging #831 soon - so this will need a rebase shortly. Once 831 merges - I can provide English lang screenshots for this.

@stefanpenner

This comment has been minimized.

Copy link
Contributor

commented Jul 20, 2014

@jdjkelly

hahaha as german is my first language, i didn't even parse that as non-english.

@ccoenen

This comment has been minimized.

Copy link
Contributor Author

commented Jul 20, 2014

I'll rebase it as soon as you want. I guess, german screenshots wouldn't be a deal breaker (the text mentions probable english texts), but english screenshots would probably cause less confusion.

@ccoenen

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2014

@jdjkelly i rebased it on top of gh-pages just now.

@ccoenen ccoenen closed this Jul 24, 2014

@ccoenen ccoenen reopened this Jul 24, 2014

@ccoenen

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2014

(sorry, wrong button)

@stefanpenner

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2014

woo!

stefanpenner added a commit that referenced this pull request Jul 24, 2014

Merge pull request #1302 from ccoenen/docs-windows-issues
adding howto disable win defender and win search index to gh-pages

@stefanpenner stefanpenner merged commit d723743 into ember-cli:gh-pages Jul 24, 2014

@stefanpenner

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2014

@ccoenen hmm, it does seem like the images are broken on http://ember-cli.com/ can you investigate?

@ccoenen

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2014

I tried fixing it, i had the same problem (see initial post of this PR), but i have no idea why it's not working.

It's not working in general locally (when / is actually the root of the project) and it's also not loading the images when ember-cli/ is the root (as on the live site). I had hoped that there's some secret magic to nanoc that eludes me.

stefanpenner added a commit that referenced this pull request Jul 26, 2014

Merge pull request #1495 from ccoenen/docs-windows-issues
Image URL fix and minor image styling, fixes #1302 minor issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.