New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort package.json according to the package.json documentation #6272

Merged
merged 7 commits into from Sep 17, 2016

Conversation

Projects
None yet
5 participants
@Turbo87
Member

Turbo87 commented Sep 16, 2016

This PR sorts our own package.json file according to the order in the documentation. It also sorts that file in the app blueprint the same way and introduces sort-package-json to make sure that the file is sorted properly for the addon blueprint too.

Note that this is also the same order that npm init will create for you.

/cc @rwjblue @stefanpenner @kellyselden

@Turbo87 Turbo87 added the Enhancement label Sep 16, 2016

@stefanpenner

This comment has been minimized.

Show comment
Hide comment
@stefanpenner

stefanpenner Sep 16, 2016

Contributor

big 👍

Contributor

stefanpenner commented Sep 16, 2016

big 👍

@kellyselden

This comment has been minimized.

Show comment
Hide comment
@kellyselden

kellyselden Sep 16, 2016

Member

Looks great!

Member

kellyselden commented Sep 16, 2016

Looks great!

@Turbo87

This comment has been minimized.

Show comment
Hide comment
@Turbo87

Turbo87 Sep 16, 2016

Member

I guess we shouldn't merge while ci is broken?

Member

Turbo87 commented Sep 16, 2016

I guess we shouldn't merge while ci is broken?

@nathanhammond

This comment has been minimized.

Show comment
Hide comment
@nathanhammond

nathanhammond Sep 16, 2016

Contributor

Confirm that we should hold merge until we fix CI. 😞

Contributor

nathanhammond commented Sep 16, 2016

Confirm that we should hold merge until we fix CI. 😞

@nathanhammond

This comment has been minimized.

Show comment
Hide comment
@nathanhammond

nathanhammond Sep 17, 2016

Contributor

Restarted builds. Didn't review closely enough to actually approve.

Contributor

nathanhammond commented Sep 17, 2016

Restarted builds. Didn't review closely enough to actually approve.

@Turbo87

This comment has been minimized.

Show comment
Hide comment
@Turbo87
Member

Turbo87 commented Sep 17, 2016

@homu r+

@homu

This comment has been minimized.

Show comment
Hide comment
@homu

homu Sep 17, 2016

Contributor

📌 Commit e385562 has been approved by Turbo87

Contributor

homu commented Sep 17, 2016

📌 Commit e385562 has been approved by Turbo87

@homu

This comment has been minimized.

Show comment
Hide comment
@homu

homu Sep 17, 2016

Contributor

⌛️ Testing commit e385562 with merge 39bbd05...

Contributor

homu commented Sep 17, 2016

⌛️ Testing commit e385562 with merge 39bbd05...

homu added a commit that referenced this pull request Sep 17, 2016

Auto merge of #6272 - Turbo87:sort-package-json, r=Turbo87
Sort package.json according to the package.json documentation

This PR sorts our own `package.json` file according to the order in the [documentation](https://docs.npmjs.com/files/package.json). It also sorts that file in the `app` blueprint the same way and introduces [sort-package-json](https://github.com/keithamus/sort-package-json) to make sure that the file is sorted properly for the `addon` blueprint too.

Note that this is also the same order that `npm init` will create for you.

/cc @rwjblue @stefanpenner @kellyselden
@homu

This comment has been minimized.

Show comment
Hide comment
@homu

homu Sep 17, 2016

Contributor

☀️ Test successful - status

Contributor

homu commented Sep 17, 2016

☀️ Test successful - status

@homu homu merged commit e385562 into ember-cli:master Sep 17, 2016

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
coverage/coveralls Coverage decreased (-0.02%) to 92.136%
Details
homu Test successful
Details

@Turbo87 Turbo87 deleted the Turbo87:sort-package-json branch Sep 17, 2016

@Turbo87 Turbo87 added this to the v2.10.0 milestone Oct 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment