New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] integrate capture exit #6423

Merged
merged 3 commits into from Nov 16, 2016

Conversation

Projects
None yet
5 participants
@stefanpenner
Contributor

stefanpenner commented Nov 9, 2016

[fixes #6422]

dependent module: https://github.com/stefanpenner/capture-exit

  • tested
  • reviewed

This PR:

  • tests green
  • test manually in situations that have this issue.

@stefanpenner stefanpenner changed the title from WIP integrate capture exit to integrate capture exit Nov 16, 2016

@stefanpenner stefanpenner changed the title from integrate capture exit to [BUGFIX] integrate capture exit Nov 16, 2016

@hjdivad

👍

@stefanpenner

This comment has been minimized.

Show comment
Hide comment
@stefanpenner

stefanpenner Nov 16, 2016

Contributor

@ember-cli/core can we consider this into beta, we are still early in the betas it may be ok? (this would help me at work :P, so I am very willing to personally deal with fallout if issues arise).

Contributor

stefanpenner commented Nov 16, 2016

@ember-cli/core can we consider this into beta, we are still early in the betas it may be ok? (this would help me at work :P, so I am very willing to personally deal with fallout if issues arise).

Show outdated Hide outdated lib/cli/index.js
Show outdated Hide outdated lib/models/builder.js
@nathanhammond

This comment has been minimized.

Show comment
Hide comment
@nathanhammond

nathanhammond Nov 16, 2016

Contributor

I'm comfortable with this going to beta. Need opinions of a couple more people.

  • Retarget PR to beta.
  • Rebase
  • Tag [BUGFIX beta]

I'd prefer to split the second two commits on this PR into a different [CLEANUP] PR to master.

Contributor

nathanhammond commented Nov 16, 2016

I'm comfortable with this going to beta. Need opinions of a couple more people.

  • Retarget PR to beta.
  • Rebase
  • Tag [BUGFIX beta]

I'd prefer to split the second two commits on this PR into a different [CLEANUP] PR to master.

@kellyselden

This comment has been minimized.

Show comment
Hide comment
@kellyselden

kellyselden Nov 16, 2016

Member

I'm fine with beta, pending @Turbo87 s comments.

Member

kellyselden commented Nov 16, 2016

I'm fine with beta, pending @Turbo87 s comments.

stefanpenner added some commits Nov 9, 2016

[BUGFIX] more resilient signal trapped cleanup
Cooperative signal handling is complicated, in-order to provide the
experience we want, we take control of this process entirely.

See: ://github.com/sindresorhus/ora/issues/27 for more context
@stefanpenner

This comment has been minimized.

Show comment
Hide comment
@stefanpenner

stefanpenner Nov 16, 2016

Contributor

#6437 beta branch

Contributor

stefanpenner commented Nov 16, 2016

#6437 beta branch

@nathanhammond

This comment has been minimized.

Show comment
Hide comment
@nathanhammond

nathanhammond Nov 16, 2016

Contributor

This PR has a bunch of weird things. Can we make this PR just the only cleanup and the addition of debug improvements?

Contributor

nathanhammond commented Nov 16, 2016

This PR has a bunch of weird things. Can we make this PR just the only cleanup and the addition of debug improvements?

@stefanpenner stefanpenner merged commit f862fe0 into master Nov 16, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.05%) to 92.932%
Details

@stefanpenner stefanpenner deleted the capture-exit branch Nov 16, 2016

@nathanhammond

This comment has been minimized.

Show comment
Hide comment
@nathanhammond

nathanhammond Nov 16, 2016

Contributor

@stefanpenner Please don't merge things like this, the capture-exit stuff is also on beta and needs to be merged back into master. Will be merge conflicts galore that I get to deal with.

Contributor

nathanhammond commented Nov 16, 2016

@stefanpenner Please don't merge things like this, the capture-exit stuff is also on beta and needs to be merged back into master. Will be merge conflicts galore that I get to deal with.

@Turbo87 Turbo87 added this to the v2.11.0 milestone Dec 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment