New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract ui to console-ui #6475

Merged
merged 1 commit into from Nov 28, 2016

Conversation

Projects
None yet
5 participants
@stefanpenner
Contributor

stefanpenner commented Nov 28, 2016

The idea is console-ui to describe a common API for other libraries to confirm to. So that, there ui output can work nicely within a larger system.

  • ui implementation
  • mock ui implementation

This enables blueprint extraction

@stefanpenner

This comment has been minimized.

Show comment
Hide comment
@stefanpenner

stefanpenner Nov 28, 2016

Contributor

code coverage decreased, but only because these files where bumping up the overall ratio. Not that test coverage actually went down, as these tests still run just in there own repository

Contributor

stefanpenner commented Nov 28, 2016

code coverage decreased, but only because these files where bumping up the overall ratio. Not that test coverage actually went down, as these tests still run just in there own repository

@stefanpenner stefanpenner changed the title from extra ui to console-ui to extract ui to console-ui Nov 28, 2016

extract ui to console-ui
The idea is console-ui to describe a common API for other libraries to confirm to. So that, there ui output can work nicely within a larger system.

* ui implementation
* mock ui implementation

@stefanpenner stefanpenner referenced this pull request Nov 28, 2016

Closed

Blprnt #6476

4 of 8 tasks complete
@rwjblue

This comment has been minimized.

Show comment
Hide comment
@rwjblue

rwjblue Nov 28, 2016

Contributor

@homu r+

Contributor

rwjblue commented Nov 28, 2016

@homu r+

@homu

This comment has been minimized.

Show comment
Hide comment
@homu

homu Nov 28, 2016

Contributor

📌 Commit 2f58ecb has been approved by rwjblue

Contributor

homu commented Nov 28, 2016

📌 Commit 2f58ecb has been approved by rwjblue

@homu

This comment has been minimized.

Show comment
Hide comment
@homu

homu Nov 28, 2016

Contributor

⚡️ Test exempted - status

Contributor

homu commented Nov 28, 2016

⚡️ Test exempted - status

@homu homu merged commit 2f58ecb into master Nov 28, 2016

3 of 4 checks passed

coverage/coveralls Coverage decreased (-2.4%) to 90.648%
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test exempted
Details

homu added a commit that referenced this pull request Nov 28, 2016

Auto merge of #6475 - ember-cli:extract-ui, r=rwjblue
extract ui to console-ui

The idea is console-ui to describe a common API for other libraries to confirm to. So that, there ui output can work nicely within a larger system.

* ui implementation
* mock ui implementation

This enables blueprint extraction

@rwjblue rwjblue deleted the extract-ui branch Nov 28, 2016

@nathanhammond nathanhammond added this to the v2.11.0 milestone Nov 28, 2016

@@ -686,7 +686,7 @@ function ensureUI(_ui) {
if (!ui) {
// TODO: one UI (lib/cli/index.js also has one for now...)
var UI = require('../ui');
var UI = require('command-ui');

This comment has been minimized.

@Turbo87

Turbo87 Nov 28, 2016

Member

typo: console-ui

@Turbo87

Turbo87 Nov 28, 2016

Member

typo: console-ui

@@ -58,7 +58,7 @@ function configureLogger(env) {
// Options: Array cliArgs, Stream inputStream, Stream outputStream
module.exports = function(options) {
var UI = options.UI || require('../ui');
var UI = options.UI || require('command-ui');

This comment has been minimized.

@Turbo87

Turbo87 Nov 28, 2016

Member

typo: console-ui

@Turbo87

Turbo87 Nov 28, 2016

Member

typo: console-ui

@Turbo87 Turbo87 referenced this pull request Nov 28, 2016

Merged

Fix "command-ui" typos #6477

homu added a commit that referenced this pull request Nov 28, 2016

@Turbo87 Turbo87 added the Internal label Nov 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment