Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blueprints/addon: Fix path to "ember" executable in ".travis.yml" #6533

Merged
merged 1 commit into from Dec 6, 2016

Conversation

Projects
None yet
5 participants
@Turbo87
Copy link
Member

commented Dec 6, 2016

Resolves the issues caused by travis-ci/travis-cookbooks#786

Note that I opened ember-cli/ember-cli-mocha#155 to test if this change actually works.

@Turbo87 Turbo87 added the Bug label Dec 6, 2016

@Turbo87

This comment has been minimized.

Copy link
Member Author

commented Dec 6, 2016

@@ -37,4 +37,4 @@ install:
script:
# Usually, it's ok to finish the test scenario without reverting
# to the addon's original dependency state, skipping "cleanup".
- ember try:one $EMBER_TRY_SCENARIO test --skip-cleanup
- node_modules/.bin/ember try:one $EMBER_TRY_SCENARIO test --skip-cleanup

This comment has been minimized.

Copy link
@blimmer

blimmer Dec 6, 2016

Contributor

This will certainly work, I proposed using npm run and created a test-ci script in package.json. It is more in line IMO with best practices, but this is a smaller change. I don't feel super strongly about it.

https://benlimmer.com/2016/12/06/ember-travis-ci-broken-builds/

This comment has been minimized.

Copy link
@rwjblue

rwjblue Dec 6, 2016

Contributor

I agree with both cases actually.

For a hot-fix in the release branch we should do the smallest possible change, which means changing this file directly to use node_modules/.bin/ember here.

We can totally address a package.json script based system later in beta/canary...

@blimmer

This comment has been minimized.

Copy link
Contributor

commented Dec 6, 2016

Travis restored the old behavior upstream (for now) travis-ci/travis-build#905

@Turbo87

This comment has been minimized.

Copy link
Member Author

commented Dec 6, 2016

yeah, we should still fix it though

@nathanhammond

This comment has been minimized.

Copy link
Contributor

commented Dec 6, 2016

@homu r+

@homu

This comment has been minimized.

Copy link
Contributor

commented Dec 6, 2016

📌 Commit 8105fb1 has been approved by nathanhammond

@homu

This comment has been minimized.

Copy link
Contributor

commented Dec 6, 2016

⚡️ Test exempted - status

@homu homu merged commit 8105fb1 into ember-cli:release Dec 6, 2016

2 of 3 checks passed

coverage/coveralls Coverage pending from Coveralls.io
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu added a commit that referenced this pull request Dec 6, 2016

Auto merge of #6533 - Turbo87:fix-addon-blueprint, r=nathanhammond
blueprints/addon: Fix path to "ember" executable in ".travis.yml"

Resolves the issues caused by travis-ci/travis-cookbooks#786

Note that I opened ember-cli/ember-cli-mocha#155 to test if this change actually works.

@Turbo87 Turbo87 deleted the Turbo87:fix-addon-blueprint branch Dec 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.