New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blueprints/app: Add `qunit-dom` dependency by default #7605

Merged
merged 1 commit into from Mar 2, 2018

Conversation

Projects
None yet
2 participants
@Turbo87
Copy link
Member

Turbo87 commented Feb 5, 2018

Resolves emberjs/ember-qunit#301

Reasons:

  • because it makes DOM assertions so much more readable

/cc @ember-cli/core @trentmwillis @cibernox

@Turbo87 Turbo87 added the Enhancement label Feb 5, 2018

@rwjblue

This comment has been minimized.

Copy link
Contributor

rwjblue commented Feb 5, 2018

I'm definitely in favor, but I think we likely need an RFC first...

@Turbo87 Turbo87 referenced this pull request Feb 12, 2018

Merged

Add `qunit-dom` dependency #116

@Turbo87 Turbo87 force-pushed the Turbo87:qunit-dom branch from 4f34acb to 8d7bf24 Feb 12, 2018

@Turbo87 Turbo87 force-pushed the Turbo87:qunit-dom branch from 8d7bf24 to a6b1b3a Mar 1, 2018

@Turbo87

This comment has been minimized.

Copy link
Member

Turbo87 commented Mar 1, 2018

ember-cli/rfcs#116 just got merged, so this PR should be good to go. I just rebased one more time.

@rwjblue

rwjblue approved these changes Mar 2, 2018

@rwjblue rwjblue merged commit d51f289 into ember-cli:master Mar 2, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.3%) to 92.824%
Details

@Turbo87 Turbo87 referenced this pull request Mar 23, 2018

Merged

Ember 3.1 Release Blog Post #3230

1 of 13 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment