New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More comprehensive detect if ember-cli is being run within CI or not. #7637

Merged
merged 1 commit into from Feb 23, 2018

Conversation

Projects
None yet
3 participants
@stefanpenner
Copy link
Contributor

stefanpenner commented Feb 20, 2018

For this, we are using: https://github.com/watson/ci-info/

Which has a pretty comprehensive support list: https://github.com/watson/ci-info/#supported-ci-tools

This aims to ensure that console-ui’s new “write errors to disk” doesn’t occur in CI: ember-cli/console-ui#19

More comprehensive detect if ember-cli is being run within CI or not.
For this, we are using: https://github.com/watson/ci-info/

Which has a pretty comprehensive support list: https://github.com/watson/ci-info/#supported-ci-tools

This aims to ensure that console-ui’s new “write errors to disk” doesn’t occur in CI: ember-cli/console-ui#19
@thoov

This comment has been minimized.

Copy link
Contributor

thoov commented Feb 20, 2018

Would it make sense to still allow process.env.CI to drive this as a fallback if ciInfo returns false?

@stefanpenner

This comment has been minimized.

Copy link
Contributor

stefanpenner commented Feb 20, 2018

Would it make sense to still allow process.env.CI to drive this as a fallback if ciInfo returns false?

Luckily, ci-info also checks process.env.CI https://github.com/watson/ci-info/blob/master/index.js#L43. So I believe we "get it for free".

@thoov

This comment has been minimized.

Copy link
Contributor

thoov commented Feb 20, 2018

Ahh, I missed that. Looks good

@rwjblue rwjblue merged commit 6e9558a into master Feb 23, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 92.525%
Details

@rwjblue rwjblue deleted the improve-ci-detection branch Feb 23, 2018

@Turbo87 Turbo87 referenced this pull request Mar 23, 2018

Merged

Ember 3.1 Release Blog Post #3230

1 of 13 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment