Exclude addon-test-support from eslint node files #7659
Conversation
This PR adds `addon-test-support` folder to excluded files from eslint override for node files. Fixes ember-cli#7652
| @@ -30,7 +30,8 @@ module.exports = { | |||
| excludedFiles: [ | |||
| 'app/**', | |||
| 'addon/**', | |||
| 'tests/dummy/app/**' | |||
| 'tests/dummy/app/**', | |||
| 'addon-test-support/**' | |||
There was a problem hiding this comment.
This should be added in the same way as the other addon specific overrides (since it doesn't apply to apps at all)
There was a problem hiding this comment.
@rwjblue sorry, not sure if I understood you. This is now inside of if statement blueprint !== 'app' which means it will be not included to apps at all. Please correct me if I am wrong.
There was a problem hiding this comment.
DOH! You are totally correct, sorry for not seeing that.
| @@ -29,7 +29,8 @@ module.exports = { | |||
| excludedFiles: [ | |||
| 'app/**', | |||
| 'addon/**', | |||
| 'tests/dummy/app/**' | |||
| 'tests/dummy/app/**', | |||
| 'addon-test-support/**' | |||
There was a problem hiding this comment.
@rwjblue there is a change for addon fixtures for yarn and npm blueprints. PR passes current tests suite which means there are no changes to app blueprint. Travis CI failed because of eslint timed out on lib folder check(it has been fixed 18b59f8).
Let me know please if I need to fix something. Thanks.
| @@ -30,7 +30,8 @@ module.exports = { | |||
| excludedFiles: [ | |||
| 'app/**', | |||
| 'addon/**', | |||
| 'tests/dummy/app/**' | |||
| 'tests/dummy/app/**', | |||
| 'addon-test-support/**' | |||
There was a problem hiding this comment.
DOH! You are totally correct, sorry for not seeing that.
This PR adds
addon-test-supportfolder to excluded files from eslint override for node files.Fix #7652